From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8CE92063DB; Tue, 4 Feb 2025 20:07:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738699667; cv=none; b=arsm3TH0wiY+CcD3iXUwxWSo3S0GvWzhXdrB+UH3sGZ25QCexOcGZoHmX5nyezQCxZZyT+oC0sm0mHACscuTGW2S2sRswPf7FNdywez4Cb+AUHHADH7iZwquWeW3yp6KZ0oiG5H49+sfIt4OoV4XuWLTt4R5iLxceEppwboOqDE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738699667; c=relaxed/simple; bh=5sSQ0HogpGQH3tWc5HY5mHvrRAVw5GKB8RCCuVydRrI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UDYQ/MOq5qz+queJs1KBFCbfz/b2T/bxWYqDJKXtAirXd23BeomDwiLjZfCdzJUUToqTR9LOYDUw52hwhhFccs0bG1IHS5XkP0YCwwTDjznIiFNCblbHtyXcIpm7/dLyulZjz8jb0vef1WWXbor6/DgDm80UOKGNDEtpG1NcJOI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WDnlRUzx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WDnlRUzx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F0B4C4CEDF; Tue, 4 Feb 2025 20:07:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738699667; bh=5sSQ0HogpGQH3tWc5HY5mHvrRAVw5GKB8RCCuVydRrI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WDnlRUzxFclO0Xz3jXXrKnPvOmh/NdHHEJcXo4quOHP9f7Z5j12nuQ5tHtjMu71rm ikQKkySUI+5jRiGCBh0gv+SICxS61f5EaFE/+tV0WN6FuN9VkD6jEv27R3sAokJq2Q AfXRmcehBvnGoaHiIBbkh2ie89WvdT3LZfLI7UsgR8PF+CuU+5NivZ+fjcflVfKC7M sdFWGBenDFAaW8qvfUBSy/M/t2vrWY/OJMJsjh1euBHOBHXosoXal7UaWgeeOZwGdk MSaNRI8Ec9yDpZSDJQ6UeAaCEBhtU27AUFOqnm6/he4Wph7fSyGm1jew9kcaxb/uUT 3h/lsh18R+EPA== Date: Tue, 4 Feb 2025 20:07:42 +0000 From: Simon Horman To: Andrew Lunn Cc: Mauro Carvalho Chehab , Jonathan Corbet , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Ferrieux , netdev@vger.kernel.org, workflows@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH net] docs: netdev: Document guidance on inline functions Message-ID: <20250204200742.GO234677@kernel.org> References: <20250203-inline-funk-v1-1-2f48418e5874@kernel.org> <874j1bt6mv.fsf@trenco.lwn.net> <20250203205039.15964b2f@foz.lan> <20250204115410.GW234677@kernel.org> Precedence: bulk X-Mailing-List: workflows@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Feb 04, 2025 at 02:25:07PM +0100, Andrew Lunn wrote: > > Thanks, perhaps something like this would help: > > > > Using inline in .h files is fine and is encouraged in place of macros > > [reference section 12]. > > The other major use of them in headers is for stub functions when an > API implementation has a Kconfig option. The question is, do we really > want to start creating such a list, and have people wanting to add to > it? Good point. Maybe it is sufficient to just make the distinction between .c and .h files.