From: Brendan Jackman <jackmanb@google.com>
To: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, workflows@vger.kernel.org,
linux-doc@vger.kernel.org, Brendan Jackman <jackmanb@google.com>
Subject: [PATCH RESEND v2 0/2] checkpatch: Add support for checkpatch-ignore note
Date: Mon, 17 Feb 2025 17:32:09 +0000 [thread overview]
Message-ID: <20250217-checkpatch-ignore-v2-0-ecfb50e03bb0@google.com> (raw)
Checkpatch sometimes has false positives. This makes it less useful for
automatic usage: tools like b4 [0] can run checkpatch on all of your
patches and give you a quick overview. When iterating on a branch, it's
tiresome to manually re-check that any errors are known false positives.
This patch adds a feature to record in the patch "graveyard" (after the
"---" that a patch might produce a certain checkpatch error, and that
this is an expected false positive.
Note, for Git users this will require some configuration changes to
adopt (see documentation patch), and not all tools that wrap Checkpatch
will automatically be able to take advantage. Changes are required for
`b4 prep --check` to work [0], I'll send that separately if this patch
is accepted.
[0] https://github.com/bjackman/b4/tree/checkpatch-ignore
Signed-off-by: Brendan Jackman <jackmanb@google.com>
---
Changes in v2:
- Switched to the "graveyard" instead of the actual commit message.
- Link to v1: https://lore.kernel.org/r/20250113-checkpatch-ignore-v1-0-63a7a740f568@google.com
---
Brendan Jackman (2):
checkpatch: Add support for checkpatch-ignore notes
docs: checkpatch: Document checkpatch-ignore feature
Documentation/dev-tools/checkpatch.rst | 46 ++++++++++++++++++++++++++++++++++
scripts/checkpatch.pl | 34 +++++++++++++++++++++++--
2 files changed, 78 insertions(+), 2 deletions(-)
---
base-commit: 619f0b6fad524f08d493a98d55bac9ab8895e3a6
change-id: 20250113-checkpatch-ignore-1096914844eb
Best regards,
--
Brendan Jackman <jackmanb@google.com>
next reply other threads:[~2025-02-17 17:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 17:32 Brendan Jackman [this message]
2025-02-17 17:32 ` [PATCH RESEND v2 1/2] checkpatch: Add support for checkpatch-ignore notes Brendan Jackman
2025-02-17 17:32 ` [PATCH RESEND v2 2/2] docs: checkpatch: Document checkpatch-ignore feature Brendan Jackman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250217-checkpatch-ignore-v2-0-ecfb50e03bb0@google.com \
--to=jackmanb@google.com \
--cc=apw@canonical.com \
--cc=corbet@lwn.net \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=konstantin@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).