Maintainer workflows discussions
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Cihan Karadag <cihan.cihan@gmail.com>
Cc: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
	Dwaipayan Ray <dwaipayanray1@gmail.com>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, workflows@vger.kernel.org,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH] checkpatch: warn about possible missing gitignore coverage in selftests
Date: Tue, 28 Jul 2026 07:31:43 -0700	[thread overview]
Message-ID: <20260728073143.0e665e36@kernel.org> (raw)
In-Reply-To: <20260728052442.626076-1-cihan.cihan@gmail.com>

On Mon, 27 Jul 2026 23:24:41 -0600 Cihan Karadag wrote:
> Per selftests documentation [1], every generated test binary must be
> added to gitignore to prevent leaving untracked files in the kernel
> tree.
> 
> This is an easy mistake to make when adding a new test. In fact, a
> search of selftests history turns up dozens of standalone follow-up
> patches with titles like "add missing gitignore for <binary>", each
> needed only because the original patch adding a new test
> didn't also update gitignore.
> 
> Add a SELFTESTS_GITIGNORE check that warns about gitignore coverage
> whenever a patch adds a new file under tools/testing/selftests/, the
> same way FILE_PATH_CHANGES warns about MAINTAINERS on any added,
> moved, or deleted file.

What percentage of changes to selftests from last 2 releases will
false-positive trigger this? Would be good to know, checkpatch has
a tendency of generating false positives which is quite counter
productive. In netdev CI at least we build the selftests and check
if there are any untracked files after.

      reply	other threads:[~2026-07-28 14:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-28  5:24 [PATCH] checkpatch: warn about possible missing gitignore coverage in selftests Cihan Karadag
2026-07-28 14:31 ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260728073143.0e665e36@kernel.org \
    --to=kuba@kernel.org \
    --cc=apw@canonical.com \
    --cc=cihan.cihan@gmail.com \
    --cc=corbet@lwn.net \
    --cc=dwaipayanray1@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=skhan@linuxfoundation.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox