Maintainer workflows discussions
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Jeff Layton <jlayton@kernel.org>,
	Andy Whitcroft <apw@canonical.com>,
	 Andrew Morton <akpm@linux-foundation.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
	Christian Brauner <brauner@kernel.org>,
		linux-kernel@vger.kernel.org, workflows@vger.kernel.org
Subject: Re: [PATCH] checkpatch.pl: adapt to new Assisted-by: format
Date: Tue, 04 Aug 2026 09:23:29 -0700	[thread overview]
Message-ID: <8b5e0ec009487b8e28210ce490e7182207466298.camel@perches.com> (raw)
In-Reply-To: <20260804-checkpatch-v1-1-27f29c79a46f@kernel.org>

On Tue, 2026-08-04 at 12:13 -0400, Jeff Layton wrote:
> There is a new format for the 'Assisted-by:' tag. Change checkpatch.pl
> to just check that it has a value rather than testing for a specific
> format.
> 
> Assisted-by: LLM

Did an LLM really help produce this?  Why?

> Signed-off-by: Jeff Layton <[jlayton@kernel.org](mailto:jlayton@kernel.org)>
> ---
> This is a companion patch to the one to change the format in
> Documentation/. See:
> 
>     [https://lore.kernel.org/workflows/87qzkuahlr.fsf@trenco.lwn.net/](https://lore.kernel.org/workflows/87qzkuahlr.fsf@trenco.lwn.net/)
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3124,11 +3124,12 @@ sub process {
>  				}
>  			}
>  
> -			# Assisted-by uses AGENT_NAME:MODEL_VERSION format, not email
> +			# Assisted-by uses a free-form value (e.g. "LLM"), not an
> +			# email address, so skip the email format checks below.
>  			if ($sign_off =~ /^Assisted-by:/i) {And
> -				if ($email !~ /^\S+:\S+/) {
> +				if ($email =~ /^\s*$/) {
>  					WARN("BAD_SIGN_OFF",
> -					     "Assisted-by expects 'AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]' format\n" . $herecurr);
> +					     "Assisted-by requires a value\n" . $herecurr);
>  				}
>  				next;
>  			}
> 
[]
> Best regards,

Sure, whatever.

cheers

  reply	other threads:[~2026-08-04 16:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04 16:13 [PATCH] checkpatch.pl: adapt to new Assisted-by: format Jeff Layton
2026-08-04 16:23 ` Joe Perches [this message]
2026-08-04 16:26   ` Jeff Layton
2026-08-05 18:54 ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b5e0ec009487b8e28210ce490e7182207466298.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=brauner@kernel.org \
    --cc=corbet@lwn.net \
    --cc=jlayton@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox