Maintainer workflows discussions
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: workflows@vger.kernel.org, ksummit@lists.linux.dev,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Mark Brown <broonie@kernel.org>, Theodore Ts'o <tytso@mit.edu>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Leon Romanovsky <leon@kernel.org>,
	Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
	Thorsten Leemhuis <linux@leemhuis.info>,
	"Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v2 4/5] agents: add a skill to find other instances of a fixed bug
Date: Fri, 16 Oct 2026 14:06:35 -0400	[thread overview]
Message-ID: <atJnq_ssIAGK-OSZ@laps> (raw)
In-Reply-To: <DM6DXZJSMPO3.J5PONDJ3HWNP@gmail.com>

On Fri, Oct 16, 2026 at 03:58:53PM +0000, Alexei Starovoitov wrote:
>On Mon, Oct 12, 2026 at 05:34 PM Sasha Levin <sashal@kernel.org> wrote:
>> +Each confirmed site is a separate bug. It needs its own fix, and its own Fixes
>> +tag and stable decision, as described in agents/skills/find-fixes/guide.rst
>> +and agents/skills/stable-tag/guide.rst. Sites in different drivers or
>> +subsystems usually get separate patches, possibly in one series.
>
>I don't think it's a right message to send to agents and humans.
>When the same mistake is made in N places the interface is the problem.
>It should be fixed in one common place.
>This text tells the agent to produce N spot fixes for N maintainers.
>We already see this issue on bpf list, let's not amplify wrong behavior.

What I had in mind was the kind of bug our scripts/coccinelle/ rules look for.

I agree that fixing the interface is better, but do we want to push all these
agents there?

So I think it should be a balance. When the skill finds the same defect
in several places, it should also ask whether the interface invites the
mistake, and if so report that the fix belongs there instead of handing
back a list for N maintainers

What do you think?

-- 
Thanks,
Sasha

  reply	other threads:[~2026-10-16 18:06 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12 21:34 [PATCH v2 0/5] agents: add skills for Fixes tags, stable tags, similar bugs, and commit messages Sasha Levin
2026-10-12 21:34 ` [PATCH v2 1/5] agents: add infrastructure for agent resources Sasha Levin
2026-10-12 21:34 ` [PATCH v2 2/5] agents: add a skill to determine Fixes tags Sasha Levin
2026-10-13  3:55   ` Kees Cook
2026-10-13  4:42   ` Michael S. Tsirkin
2026-10-15  8:03     ` Dan Carpenter
2026-10-12 21:34 ` [PATCH v2 3/5] agents: add a skill to determine stable tags Sasha Levin
2026-10-13  3:59   ` Kees Cook
2026-10-13 11:30     ` Sasha Levin
2026-10-12 21:34 ` [PATCH v2 4/5] agents: add a skill to find other instances of a fixed bug Sasha Levin
2026-10-13  4:02   ` Kees Cook
2026-10-13 11:14     ` Sasha Levin
2026-10-16 15:58   ` Alexei Starovoitov
2026-10-16 18:06     ` Sasha Levin [this message]
2026-10-16 18:24       ` Alexei Starovoitov
2026-10-12 21:34 ` [PATCH v2 5/5] agents: add a skill to write commit messages Sasha Levin
2026-10-12 22:47 ` [PATCH v2 0/5] agents: add skills for Fixes tags, stable tags, similar bugs, and " Jonathan Corbet
2026-10-13  3:48   ` Kees Cook
2026-10-13 11:22     ` Sasha Levin
2026-10-14 13:51     ` Geert Uytterhoeven
2026-10-15  4:50       ` Kees Cook
2026-10-15 13:37         ` Theodore Tso
2026-10-15 14:35           ` Thorsten Leemhuis
2026-10-15 15:34             ` Kees Cook
2026-10-16 14:49       ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atJnq_ssIAGK-OSZ@laps \
    --to=sashal@kernel.org \
    --cc=alexei.starovoitov@gmail.com \
    --cc=broonie@kernel.org \
    --cc=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=ksummit@lists.linux.dev \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=leon@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@leemhuis.info \
    --cc=mst@redhat.com \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tytso@mit.edu \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox