From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:36736 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727054AbfFNL6V (ORCPT ); Fri, 14 Jun 2019 07:58:21 -0400 Date: Fri, 14 Jun 2019 13:58:06 +0200 From: Jesper Dangaard Brouer Subject: Re: [PATCH bpf 2/3] devmap: Add missing bulk queue free Message-ID: <20190614135806.4bcb1a31@carbon> In-Reply-To: <20190614082015.23336-3-toshiaki.makita1@gmail.com> References: <20190614082015.23336-1-toshiaki.makita1@gmail.com> <20190614082015.23336-3-toshiaki.makita1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: xdp-newbies-owner@vger.kernel.org List-ID: To: Toshiaki Makita Cc: Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , netdev@vger.kernel.org, xdp-newbies@vger.kernel.org, bpf@vger.kernel.org, "Michael S. Tsirkin" , Jason Wang , David Ahern , brouer@redhat.com On Fri, 14 Jun 2019 17:20:14 +0900 Toshiaki Makita wrote: > dev_map_free() forgot to free bulk queue when freeing its entries. > > Fixes: 5d053f9da431 ("bpf: devmap prepare xdp frames for bulking") > Signed-off-by: Toshiaki Makita > --- > kernel/bpf/devmap.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c > index e001fb1..a126d95 100644 > --- a/kernel/bpf/devmap.c > +++ b/kernel/bpf/devmap.c > @@ -186,6 +186,7 @@ static void dev_map_free(struct bpf_map *map) > if (!dev) > continue; > > + free_percpu(dev->bulkq); > dev_put(dev->dev); > kfree(dev); > } Do we need to call need to call dev_map_flush_old() before free_percpu(dev->bulkq) ? Looking the code, I guess this is not needed as, above we are ensuring all pending flush operations have completed. Acked-by: Jesper Dangaard Brouer -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer