From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f196.google.com ([209.85.208.196]:37398 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727262AbfFNLHp (ORCPT ); Fri, 14 Jun 2019 07:07:45 -0400 Received: by mail-lj1-f196.google.com with SMTP id 131so1981357ljf.4 for ; Fri, 14 Jun 2019 04:07:44 -0700 (PDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: Re: [PATCH bpf 3/3] devmap: Add missing RCU read lock on flush In-Reply-To: <20190614082015.23336-4-toshiaki.makita1@gmail.com> References: <20190614082015.23336-1-toshiaki.makita1@gmail.com> <20190614082015.23336-4-toshiaki.makita1@gmail.com> Date: Fri, 14 Jun 2019 13:07:42 +0200 Message-ID: <874l4sctmp.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Sender: xdp-newbies-owner@vger.kernel.org List-ID: To: Toshiaki Makita , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend Cc: netdev@vger.kernel.org, xdp-newbies@vger.kernel.org, bpf@vger.kernel.org, "Michael S. Tsirkin" , Jason Wang , David Ahern Toshiaki Makita writes: > .ndo_xdp_xmit() assumes it is called under RCU. For example virtio_net > uses RCU to detect it has setup the resources for tx. The assumption > accidentally broke when introducing bulk queue in devmap. > > Fixes: 5d053f9da431 ("bpf: devmap prepare xdp frames for bulking") > Reported-by: David Ahern > Signed-off-by: Toshiaki Makita > --- I think this is still needed, but the patch context is going to conflict with the patch I linked above... I guess it's up to the maintainers to decide which order to merge them in :) -Toke