From: Andres Lagar-Cavilla <andres@lagarcavilla.org>
To: xen-devel@lists.xen.org
Cc: "Zhang, Yang Z" <yang.z.zhang@intel.com>,
keir@xen.org, andres@gridcentric.ca, tim@xen.org
Subject: [PATCH 1 of 4] x86/mm: Eliminate _shadow_mode_refcounts
Date: Fri, 27 Apr 2012 17:16:18 -0400 [thread overview]
Message-ID: <00034349414ec903179d.1335561378@xdev.gridcentric.ca> (raw)
In-Reply-To: <patchbomb.1335561377@xdev.gridcentric.ca>
xen/arch/x86/mm.c | 2 +-
xen/arch/x86/mm/shadow/common.c | 5 -----
xen/include/asm-x86/mm.h | 1 -
3 files changed, 1 insertions(+), 7 deletions(-)
Replace it with the proper paging_mode_refcounts. This was causing spurious
and abundant verbiage from Xen for the
!get_page(page, d) && !get_page(page, dom_cow)
sequence in get_page_from_gfn
Signed-off-by: Andres Lagar-Cavilla <andres@lagarcavilla.org>
diff -r 40938dc16dfa -r 00034349414e xen/arch/x86/mm.c
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -2167,7 +2167,7 @@ int get_page(struct page_info *page, str
if ( owner != NULL )
put_page(page);
- if ( !_shadow_mode_refcounts(domain) && !domain->is_dying )
+ if ( !paging_mode_refcounts(domain) && !domain->is_dying )
gdprintk(XENLOG_INFO,
"Error pfn %lx: rd=%p, od=%p, caf=%08lx, taf=%"
PRtype_info "\n",
diff -r 40938dc16dfa -r 00034349414e xen/arch/x86/mm/shadow/common.c
--- a/xen/arch/x86/mm/shadow/common.c
+++ b/xen/arch/x86/mm/shadow/common.c
@@ -105,11 +105,6 @@ static int __init shadow_audit_key_init(
__initcall(shadow_audit_key_init);
#endif /* SHADOW_AUDIT */
-int _shadow_mode_refcounts(struct domain *d)
-{
- return shadow_mode_refcounts(d);
-}
-
/**************************************************************************/
/* x86 emulator support for the shadow code
diff -r 40938dc16dfa -r 00034349414e xen/include/asm-x86/mm.h
--- a/xen/include/asm-x86/mm.h
+++ b/xen/include/asm-x86/mm.h
@@ -331,7 +331,6 @@ static inline void *__page_to_virt(const
int free_page_type(struct page_info *page, unsigned long type,
int preemptible);
-int _shadow_mode_refcounts(struct domain *d);
int is_iomem_page(unsigned long mfn);
next prev parent reply other threads:[~2012-04-27 21:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 21:16 [PATCH 0 of 4] RFC top up to experimental p2m rwlock patch Andres Lagar-Cavilla
2012-04-27 21:16 ` Andres Lagar-Cavilla [this message]
2012-05-03 16:24 ` [PATCH 1 of 4] x86/mm: Eliminate _shadow_mode_refcounts Tim Deegan
2012-04-27 21:16 ` [PATCH 2 of 4] Grant table: Adopt get_page_from_gfn Andres Lagar-Cavilla
2012-04-27 21:16 ` [PATCH 3 of 4] Use get page from gfn also in svm code Andres Lagar-Cavilla
2012-04-27 21:16 ` [PATCH 4 of 4] Expand use of get_page_from_gfn Andres Lagar-Cavilla
2012-05-03 16:19 ` [PATCH 0 of 4] RFC top up to experimental p2m rwlock patch Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00034349414ec903179d.1335561378@xdev.gridcentric.ca \
--to=andres@lagarcavilla.org \
--cc=andres@gridcentric.ca \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).