* [PATCH] xen: platform-pci: use DEFINE_PCI_DEVICE_TABLE macro
@ 2013-11-28 3:48 Jingoo Han
2013-11-28 4:41 ` Jingoo Han
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-11-28 3:48 UTC (permalink / raw)
To: 'Konrad Rzeszutek Wilk'
Cc: xen-devel, 'Boris Ostrovsky', 'Jingoo Han',
'David Vrabel'
This macro is used to create a struct pci_device_id array.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/xen/platform-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c
index 2f3528e..7ab5e81 100644
--- a/drivers/xen/platform-pci.c
+++ b/drivers/xen/platform-pci.c
@@ -170,7 +170,7 @@ pci_out:
return ret;
}
-static struct pci_device_id platform_pci_tbl[] = {
+static DEFINE_PCI_DEVICE_TABLE(platform_pci_tbl) = {
{PCI_VENDOR_ID_XEN, PCI_DEVICE_ID_XEN_PLATFORM,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
{0,}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xen: platform-pci: use DEFINE_PCI_DEVICE_TABLE macro
2013-11-28 3:48 [PATCH] xen: platform-pci: use DEFINE_PCI_DEVICE_TABLE macro Jingoo Han
@ 2013-11-28 4:41 ` Jingoo Han
0 siblings, 0 replies; 2+ messages in thread
From: Jingoo Han @ 2013-11-28 4:41 UTC (permalink / raw)
To: 'Konrad Rzeszutek Wilk'
Cc: xen-devel, 'Boris Ostrovsky', 'Jingoo Han',
'David Vrabel'
On Thursday, November 28, 2013 12:48 PM, Jingoo Han wrote:
>
> This macro is used to create a struct pci_device_id array.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Please, ignore this patch.
According to the Greg Kroah-Hartman,
"Yeah, and it's a horrid macro that deserves to be removed, please don't
use it in more places.
Actually, if you could just remove it, that would be best, sorry, I'm
not going to take these patches."
So, I will send the patch to remove 'DEFINE_PCI_DEVICE_TABLE' instead.
Sorry for annoying. :-)
Best regards,
Jingoo Han
> ---
> drivers/xen/platform-pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c
> index 2f3528e..7ab5e81 100644
> --- a/drivers/xen/platform-pci.c
> +++ b/drivers/xen/platform-pci.c
> @@ -170,7 +170,7 @@ pci_out:
> return ret;
> }
>
> -static struct pci_device_id platform_pci_tbl[] = {
> +static DEFINE_PCI_DEVICE_TABLE(platform_pci_tbl) = {
> {PCI_VENDOR_ID_XEN, PCI_DEVICE_ID_XEN_PLATFORM,
> PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
> {0,}
> --
> 1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-28 4:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-28 3:48 [PATCH] xen: platform-pci: use DEFINE_PCI_DEVICE_TABLE macro Jingoo Han
2013-11-28 4:41 ` Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).