From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jingoo Han Subject: Re: [PATCH] xen: platform-pci: use DEFINE_PCI_DEVICE_TABLE macro Date: Thu, 28 Nov 2013 13:41:07 +0900 Message-ID: <005901ceebf4$0e024360$2a06ca20$%han@samsung.com> References: <004f01ceebec$a35d4110$ea17c330$%han@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VltPc-0007Lt-Qk for xen-devel@lists.xenproject.org; Thu, 28 Nov 2013 04:41:13 +0000 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MWY00KSWICKWO30@mailout1.samsung.com> for xen-devel@lists.xenproject.org; Thu, 28 Nov 2013 13:41:08 +0900 (KST) In-reply-to: <004f01ceebec$a35d4110$ea17c330$%han@samsung.com> Content-language: ko List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: 'Konrad Rzeszutek Wilk' Cc: xen-devel@lists.xenproject.org, 'Boris Ostrovsky' , 'Jingoo Han' , 'David Vrabel' List-Id: xen-devel@lists.xenproject.org On Thursday, November 28, 2013 12:48 PM, Jingoo Han wrote: > > This macro is used to create a struct pci_device_id array. > > Signed-off-by: Jingoo Han Please, ignore this patch. According to the Greg Kroah-Hartman, "Yeah, and it's a horrid macro that deserves to be removed, please don't use it in more places. Actually, if you could just remove it, that would be best, sorry, I'm not going to take these patches." So, I will send the patch to remove 'DEFINE_PCI_DEVICE_TABLE' instead. Sorry for annoying. :-) Best regards, Jingoo Han > --- > drivers/xen/platform-pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c > index 2f3528e..7ab5e81 100644 > --- a/drivers/xen/platform-pci.c > +++ b/drivers/xen/platform-pci.c > @@ -170,7 +170,7 @@ pci_out: > return ret; > } > > -static struct pci_device_id platform_pci_tbl[] = { > +static DEFINE_PCI_DEVICE_TABLE(platform_pci_tbl) = { > {PCI_VENDOR_ID_XEN, PCI_DEVICE_ID_XEN_PLATFORM, > PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, > {0,} > -- > 1.7.10.4