From: Jaeyong Yoo <jaeyong.yoo@samsung.com>
To: 'Ian Campbell' <Ian.Campbell@citrix.com>
Cc: 'Julien Grall' <julien.grall@citrix.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH v4 8/9] xen/arm: Implement hypercall for dirty page tracing
Date: Tue, 08 Oct 2013 18:46:41 +0900 [thread overview]
Message-ID: <007301cec40b$4a9fbcf0$dfdf36d0$%yoo@samsung.com> (raw)
In-Reply-To: <1381221960.9920.4.camel@kazak.uk.xensource.com>
> -----Original Message-----
> From: xen-devel-bounces@lists.xen.org [mailto:xen-devel-
> bounces@lists.xen.org] On Behalf Of Ian Campbell
> Sent: Tuesday, October 08, 2013 5:46 PM
> To: jaeyong.yoo@samsung.com
> Cc: Julien Grall; xen-devel@lists.xen.org
> Subject: Re: [Xen-devel] [PATCH v4 8/9] xen/arm: Implement hypercall for
> dirty page tracing
>
> On Tue, 2013-10-08 at 06:29 +0000, Jaeyong Yoo wrote:
>
> > >> + /* handle permission fault on write */
> > >> + if ( page_fault )
> > >> + {
> > >> + if ( current->domain->arch.dirty.mode == 0 )
> > >> + goto bad_data_abort;
> > >> +
> > >> + handle_page_fault(current->domain, info.gpa);
> > >
> > >You must call advance_pc(regs, hsr) here.
> >
> > I got it.
>
> Are you sure about this? Eugene's reasoning that we need to replay the
> faulting instruction seemed pretty sound.
Oh, I've got confused. I think Eugene's reasoning is correct.
handle_mmio is for emulating and handle_page_fault is the generic fault,
which should be resolved and repeat the instruction.
Sorry for the confusion.
Jaeyong
>
> Ian.
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-10-08 9:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 6:29 [PATCH v4 8/9] xen/arm: Implement hypercall for dirty page tracing Jaeyong Yoo
2013-10-08 8:46 ` Ian Campbell
2013-10-08 9:46 ` Jaeyong Yoo [this message]
2013-10-08 15:36 ` Eugene Fedotov
2013-10-10 14:13 ` Julien Grall
2013-10-16 13:44 ` Ian Campbell
-- strict thread matches above, loose matches on Subject: below --
2013-10-20 4:22 Jaeyong Yoo
2013-10-04 4:43 [PATCH v4 0/9] xen/arm: live migration support in arndale board Jaeyong Yoo
2013-10-04 4:44 ` [PATCH v4 8/9] xen/arm: Implement hypercall for dirty page tracing Jaeyong Yoo
2013-10-07 13:02 ` Julien Grall
2013-10-07 15:51 ` Eugene Fedotov
2013-10-10 14:10 ` Julien Grall
2013-10-16 13:44 ` Ian Campbell
2013-10-17 10:12 ` Jaeyong Yoo
2013-10-17 10:30 ` Ian Campbell
2013-10-17 11:05 ` Jaeyong Yoo
2013-10-17 11:47 ` Ian Campbell
2013-10-18 4:17 ` Jaeyong Yoo
2013-10-18 9:11 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='007301cec40b$4a9fbcf0$dfdf36d0$%yoo@samsung.com' \
--to=jaeyong.yoo@samsung.com \
--cc=Ian.Campbell@citrix.com \
--cc=julien.grall@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).