From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jaeyong Yoo <jaeyong.yoo@samsung.com>
Subject: Re: [PATCH v4 8/9] xen/arm: Implement hypercall for
 dirty page tracing
Date: Tue, 08 Oct 2013 18:46:41 +0900
Message-ID: <007301cec40b$4a9fbcf0$dfdf36d0$%yoo@samsung.com>
References: <25269810.259001381213751804.JavaMail.weblogic@epml25>
	<1381221960.9920.4.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-reply-to: <1381221960.9920.4.camel@kazak.uk.xensource.com>
Content-language: ko
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: 'Ian Campbell' <Ian.Campbell@citrix.com>
Cc: 'Julien Grall' <julien.grall@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

> -----Original Message-----
> From: xen-devel-bounces@lists.xen.org [mailto:xen-devel-
> bounces@lists.xen.org] On Behalf Of Ian Campbell
> Sent: Tuesday, October 08, 2013 5:46 PM
> To: jaeyong.yoo@samsung.com
> Cc: Julien Grall; xen-devel@lists.xen.org
> Subject: Re: [Xen-devel] [PATCH v4 8/9] xen/arm: Implement hypercall for
> dirty page tracing
> 
> On Tue, 2013-10-08 at 06:29 +0000, Jaeyong Yoo wrote:
> 
> > >> +    /* handle permission fault on write */
> > >> +    if ( page_fault )
> > >> +    {
> > >> +        if ( current->domain->arch.dirty.mode == 0 )
> > >> +           goto bad_data_abort;
> > >> +
> > >> +        handle_page_fault(current->domain, info.gpa);
> > >
> > >You must call advance_pc(regs, hsr) here.
> >
> > I got it.
> 
> Are you sure about this? Eugene's reasoning that we need to replay the
> faulting instruction seemed pretty sound.

Oh, I've got confused. I think Eugene's reasoning is correct.
handle_mmio is for emulating and handle_page_fault is the generic fault,
which should be resolved and repeat the instruction. 
Sorry for the confusion.

Jaeyong

> 
> Ian.
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel