From: George Dunlap <george.dunlap@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: george.dunlap@eu.citrix.com
Subject: [PATCH 3 of 3 v2] libxl: Warn that /usr/bin/pygrub is deprecated
Date: Tue, 15 May 2012 11:33:06 +0100 [thread overview]
Message-ID: <01804c550dd1e9fc51c1.1337077986@kodo2> (raw)
In-Reply-To: <patchbomb.1337077983@kodo2>
v2: Use strcmp rather than strncmp.
Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
diff -r 4503705206f3 -r 01804c550dd1 tools/libxl/libxl_bootloader.c
--- a/tools/libxl/libxl_bootloader.c Tue May 15 11:20:55 2012 +0100
+++ b/tools/libxl/libxl_bootloader.c Tue May 15 11:28:12 2012 +0100
@@ -15,6 +15,7 @@
#include "libxl_osdeps.h" /* must come before any other headers */
#include <termios.h>
+#include <string.h>
#include "libxl_internal.h"
@@ -401,6 +402,11 @@ int libxl_run_bootloader(libxl_ctx *ctx,
LIBXL__LOG(ctx, LIBXL__LOG_DEBUG, "Config bootloader path: %s",
info->u.pv.bootloader);
+ if ( !strcmp(info->u.pv.bootloader, "/usr/bin/pygrub") )
+ LIBXL__LOG(ctx, LIBXL__LOG_WARNING,
+ "WARNING: bootloader='/usr/bin/pygrub' " \
+ "is deprecated; use bootloader='pygrub' instead");
+
bootloader = libxl__abs_path(gc, info->u.pv.bootloader,
libxl__libexec_path());
if ( bootloader == NULL ) {
next prev parent reply other threads:[~2012-05-15 10:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 10:33 [PATCH 0 of 3 v2] tools: Move bootloaders to libexec directory George Dunlap
2012-05-15 10:33 ` [PATCH 1 of 3 v2] libxl: Look for bootloader in libexec path George Dunlap
2012-05-15 13:49 ` Ian Campbell
2012-05-15 10:33 ` [PATCH 2 of 3 v2] tools: Install pv bootloaders in libexec rather than /usr/bin George Dunlap
2012-05-15 13:50 ` Ian Campbell
2012-05-15 10:33 ` George Dunlap [this message]
2012-05-15 13:50 ` [PATCH 3 of 3 v2] libxl: Warn that /usr/bin/pygrub is deprecated Ian Campbell
2012-05-15 11:12 ` [PATCH 0 of 3 v2] tools: Move bootloaders to libexec directory George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01804c550dd1e9fc51c1.1337077986@kodo2 \
--to=george.dunlap@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).