From: Dario Faggioli <dfaggioli@suse.com>
To: Ian Jackson <ian.jackson@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>,
George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH] tools: libxl/xl: run NUMA placement even when an hard-affinity is set
Date: Tue, 21 Aug 2018 17:14:52 +0200 [thread overview]
Message-ID: <0272aceb4d34d1d9f4a92c1b6faaede59a1242a8.camel@suse.com> (raw)
In-Reply-To: <23419.59543.385873.125444@mariner.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 912 bytes --]
On Tue, 2018-08-21 at 11:25 +0100, Ian Jackson wrote:
> Dario Faggioli writes ("Re: [Xen-devel] [PATCH] tools: libxl/xl: run
> NUMA placement even when an hard-affinity is set"):
> > On Mon, 2018-08-20 at 11:14 +0100, Wei Liu wrote:
> > > You can use NDEBUG instead.
> >
> > But I don't have a too strong opinion; I'll change it to us NDEBUG
> > if
> > that's what you prefer.
>
> Please do not use NDEBUG. libxl is not designed to be compiled with
> NDEBUG.
>
Err.. Ok. So, what do I do?
Do I leave it under this special "manually enable for development and
testing" kind of thing?
Do I make it always on?
Do I get rid of it?
:-)
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Software Engineer @ SUSE https://www.suse.com/
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-08-21 15:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 17:03 [PATCH] tools: libxl/xl: run NUMA placement even when an hard-affinity is set Dario Faggioli
2018-08-20 10:14 ` Wei Liu
2018-08-20 14:22 ` Dario Faggioli
2018-08-21 10:25 ` Ian Jackson
2018-08-21 15:14 ` Dario Faggioli [this message]
2018-08-21 15:31 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0272aceb4d34d1d9f4a92c1b6faaede59a1242a8.camel@suse.com \
--to=dfaggioli@suse.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).