[PATCH 1/1] hw/intc/arm_gicv3_its: Fix the VM termination in vm_change_state_handler()

[PATCH 1/1] hw/intc/arm_gicv3_its: Fix the VM termination in vm_change_state_handler()

[Shanker Donthineni]

The commit cddafd8f353d ("hw/intc/arm_gicv3_its: Implement state save
/restore") breaks the backward compatibility with the older kernels
where vITS save/restore support is not available. The vmstate function
vm_change_state_handler() should not be registered if the running kernel
doesn't support ITS save/restore feature. Otherwise VM instance will be
killed whenever vmstate callback function is invoked.

Observed a virtual machine shutdown with QEMU-2.10+linux-4.11 when testing
the reboot command "virsh reboot <domain> --mode acpi" instead of reboot.

KVM Error: 'KVM_SET_DEVICE_ATTR failed: Group 4 attr 0x00000000000001'

Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>
---
 hw/intc/arm_gicv3_its_kvm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/intc/arm_gicv3_its_kvm.c b/hw/intc/arm_gicv3_its_kvm.c
index 39903d5..9b00ce5 100644
--- a/hw/intc/arm_gicv3_its_kvm.c
+++ b/hw/intc/arm_gicv3_its_kvm.c
@@ -111,13 +111,13 @@ static void kvm_arm_its_realize(DeviceState *dev, Error **errp)
             error_free(s->migration_blocker);
             return;
         }
+    } else {
+        qemu_add_vm_change_state_handler(vm_change_state_handler, s);
     }
 
     kvm_msi_use_devid = true;
     kvm_gsi_direct_mapping = false;
     kvm_msi_via_irqfd_allowed = kvm_irqfds_enabled();
-
-    qemu_add_vm_change_state_handler(vm_change_state_handler, s);
 }
 
 /**
-- 
Qualcomm Datacenter Technologies, Inc. on behalf of the Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 1/1] hw/intc/arm_gicv3_its: Fix the VM termination in vm_change_state_handler()

[Julien Grall]

Hi Shanker,

I think you sent this patch to the wrong ML and people. This patch seem 
KVM specific.

Cheers,

On 03/11/17 11:33, Shanker Donthineni wrote:
> The commit cddafd8f353d ("hw/intc/arm_gicv3_its: Implement state save
> /restore") breaks the backward compatibility with the older kernels
> where vITS save/restore support is not available. The vmstate function
> vm_change_state_handler() should not be registered if the running kernel
> doesn't support ITS save/restore feature. Otherwise VM instance will be
> killed whenever vmstate callback function is invoked.
> 
> Observed a virtual machine shutdown with QEMU-2.10+linux-4.11 when testing
> the reboot command "virsh reboot <domain> --mode acpi" instead of reboot.
> 
> KVM Error: 'KVM_SET_DEVICE_ATTR failed: Group 4 attr 0x00000000000001'
> 
> Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>
> ---
>   hw/intc/arm_gicv3_its_kvm.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/intc/arm_gicv3_its_kvm.c b/hw/intc/arm_gicv3_its_kvm.c
> index 39903d5..9b00ce5 100644
> --- a/hw/intc/arm_gicv3_its_kvm.c
> +++ b/hw/intc/arm_gicv3_its_kvm.c
> @@ -111,13 +111,13 @@ static void kvm_arm_its_realize(DeviceState *dev, Error **errp)
>               error_free(s->migration_blocker);
>               return;
>           }
> +    } else {
> +        qemu_add_vm_change_state_handler(vm_change_state_handler, s);
>       }
>   
>       kvm_msi_use_devid = true;
>       kvm_gsi_direct_mapping = false;
>       kvm_msi_via_irqfd_allowed = kvm_irqfds_enabled();
> -
> -    qemu_add_vm_change_state_handler(vm_change_state_handler, s);
>   }
>   
>   /**
> 

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 1/1] hw/intc/arm_gicv3_its: Fix the VM termination in vm_change_state_handler()

[Shanker Donthineni]

Thanks Julien, sorry for sending to XEN mailing list and it was my mistake.

Thanks,
Shanker

-----Original Message-----
From: Xen-devel [mailto:xen-devel-bounces@lists.xen.org] On Behalf Of Julien Grall
Sent: Friday, November 3, 2017 6:51 AM
To: Shanker Donthineni <shankerd@codeaurora.org>; xen-devel <xen-devel@lists.xensource.com>; Julien Grall <julien.grall@arm.com>; Stefano Stabellini <sstabellini@kernel.org>
Cc: Philip Elcan <pelcan@codeaurora.org>; Vikram Sethi <vikrams@codeaurora.org>
Subject: Re: [Xen-devel] [PATCH 1/1] hw/intc/arm_gicv3_its: Fix the VM termination in vm_change_state_handler()

Hi Shanker,

I think you sent this patch to the wrong ML and people. This patch seem KVM specific.

Cheers,

On 03/11/17 11:33, Shanker Donthineni wrote:
> The commit cddafd8f353d ("hw/intc/arm_gicv3_its: Implement state save
> /restore") breaks the backward compatibility with the older kernels 
> where vITS save/restore support is not available. The vmstate function
> vm_change_state_handler() should not be registered if the running 
> kernel doesn't support ITS save/restore feature. Otherwise VM instance 
> will be killed whenever vmstate callback function is invoked.
> 
> Observed a virtual machine shutdown with QEMU-2.10+linux-4.11 when 
> testing the reboot command "virsh reboot <domain> --mode acpi" instead of reboot.
> 
> KVM Error: 'KVM_SET_DEVICE_ATTR failed: Group 4 attr 0x00000000000001'
> 
> Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>
> ---
>   hw/intc/arm_gicv3_its_kvm.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/intc/arm_gicv3_its_kvm.c b/hw/intc/arm_gicv3_its_kvm.c 
> index 39903d5..9b00ce5 100644
> --- a/hw/intc/arm_gicv3_its_kvm.c
> +++ b/hw/intc/arm_gicv3_its_kvm.c
> @@ -111,13 +111,13 @@ static void kvm_arm_its_realize(DeviceState *dev, Error **errp)
>               error_free(s->migration_blocker);
>               return;
>           }
> +    } else {
> +        qemu_add_vm_change_state_handler(vm_change_state_handler, s);
>       }
>   
>       kvm_msi_use_devid = true;
>       kvm_gsi_direct_mapping = false;
>       kvm_msi_via_irqfd_allowed = kvm_irqfds_enabled();
> -
> -    qemu_add_vm_change_state_handler(vm_change_state_handler, s);
>   }
>   
>   /**
> 

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel