From: Juergen Gross <jgross@suse.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: ross.lagerwall@citrix.com, dave@recoil.org, wei.liu2@citrix.com,
andrew.cooper3@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v2 2/2] tools: make xenstore domain easy configurable
Date: Wed, 20 Jul 2016 13:18:42 +0200 [thread overview]
Message-ID: <04fb317f-71a9-8692-5e5f-ff3cc689c8ce@suse.com> (raw)
In-Reply-To: <22415.21972.552233.90013@mariner.uk.xensource.com>
On 20/07/16 12:43, Ian Jackson wrote:
> Juergen Gross writes ("[PATCH v2 2/2] tools: make xenstore domain easy configurable"):
>> Add configuration entries to sysconfig.xencommons for selection of the
>> xenstore type (domain or daemon) and start the selected xenstore
>> service via a script called from sysvinit or systemd.
>
> Can you please split this up into two patches,
> * Break launch-xenstore out of xencommons (no functional change)
> * Use launch-xenstore instead of sockets with systemd
> ?
>
> As ever it's a lot easier to review the functional change when it's
> not mixed in with code motion.
>
> I suspect that the latter mnay need to be combined with parts of what
> is currently 1/2, since AFAICT after applying 1 nothing starts
> xenstored any more under systemd.
>
> (Also your patch again contains a patch to configure but no
> corresponding patch to the source file(s).)
Okay, I'll have a try.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-07-20 11:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 7:58 [PATCH v2 0/2] tools: make xenstore domain/daemon configurable Juergen Gross
2016-07-20 7:58 ` [PATCH v2 1/2] tools: remove systemd xenstore socket definitions Juergen Gross
2016-07-20 10:36 ` Ian Jackson
2016-07-20 11:17 ` Juergen Gross
2016-07-20 7:58 ` [PATCH v2 2/2] tools: make xenstore domain easy configurable Juergen Gross
2016-07-20 10:43 ` Ian Jackson
2016-07-20 11:18 ` Juergen Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04fb317f-71a9-8692-5e5f-ff3cc689c8ce@suse.com \
--to=jgross@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=dave@recoil.org \
--cc=ian.jackson@eu.citrix.com \
--cc=ross.lagerwall@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).