From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>, Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Tim Deegan <tim@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>,
Julien Grall <julien.grall@arm.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/3] xmalloc: correct _xmalloc_array() indentation
Date: Thu, 18 May 2017 11:16:45 +0100 [thread overview]
Message-ID: <055dfb0e-fb04-f23e-4115-bcf64219aedb@citrix.com> (raw)
In-Reply-To: <20170518094037.g7375gz265rjfvgr@citrix.com>
On 18/05/17 10:40, Wei Liu wrote:
> On Thu, May 18, 2017 at 02:39:45AM -0600, Jan Beulich wrote:
>> It's been wrongly indented using tabs till now, and the stray blank
>> ahead of the final return statement gets in the way of using .i files
>> for detailed analysis of other compiler issues
>> (-Wmisleading-indentation kickin in due to the tab->space
> kickin -> kicks
>
>> transformation done in the course of pre-processing).
>>
>> Also add missing spaces inside the if() at once, including the similar
>> case in _xzalloc_array().
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-05-18 10:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 8:01 [PATCH 0/3] gcc 7 build fixes (hypervisor side) Jan Beulich
2017-05-18 8:34 ` Julien Grall
2017-05-18 8:42 ` Jan Beulich
2017-05-18 8:39 ` [PATCH 1/3] xmalloc: correct _xmalloc_array() indentation Jan Beulich
2017-05-18 9:40 ` Wei Liu
2017-05-18 10:16 ` Andrew Cooper [this message]
2017-05-18 8:40 ` [PATCH 2/3] x86: fix build with gcc 7 Jan Beulich
2017-05-18 10:18 ` Andrew Cooper
2017-05-18 8:41 ` [PATCH 3/3] arm: " Jan Beulich
2017-05-18 15:12 ` Julien Grall
2017-05-18 18:35 ` Stefano Stabellini
2017-05-19 6:45 ` Jan Beulich
2017-05-19 6:16 ` Jan Beulich
2017-05-19 7:48 ` Julien Grall
2017-05-18 15:14 ` [PATCH 0/3] gcc 7 build fixes (hypervisor side) Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=055dfb0e-fb04-f23e-4115-bcf64219aedb@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).