From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 2/2] x86/pagewalk: Fix pagewalk's handling of instruction fetches Date: Thu, 1 Jun 2017 12:22:34 +0100 Message-ID: <0614feaa-5ea0-adce-106c-dc4745b4835d@citrix.com> References: <1495818213-345-1-git-send-email-andrew.cooper3@citrix.com> <1495818213-345-3-git-send-email-andrew.cooper3@citrix.com> <592BFED4020000780015D347@prv-mh.provo.novell.com> <0e4ea8ae-be0c-4d69-61f8-ca75c3faa029@citrix.com> <592C02C9020000780015D371@prv-mh.provo.novell.com> <6c3c894f-c92c-a172-ab67-954cbba6220a@citrix.com> <59300DBD020000780015EA20@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <59300DBD020000780015EA20@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: George Dunlap , Tim Deegan , Xen-devel List-Id: xen-devel@lists.xenproject.org T24gMDEvMDYvMTcgMTE6NTEsIEphbiBCZXVsaWNoIHdyb3RlOgo+Pj4+IE9uIDAxLjA2LjE3IGF0 IDEyOjE5LCA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3JvdGU6Cj4+IE9uIDI5LzA1LzE3 IDEwOjE1LCBKYW4gQmV1bGljaCB3cm90ZToKPj4+Pj4+IE9uIDI5LjA1LjE3IGF0IDExOjAzLCA8 YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3JvdGU6Cj4+Pj4gT24gMjkvMDUvMjAxNyAwOTo1 OCwgSmFuIEJldWxpY2ggd3JvdGU6Cj4+Pj4+Pj4+IE9uIDI2LjA1LjE3IGF0IDE5OjAzLCA8YW5k cmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3JvdGU6Cj4+Pj4+PiAtLS0gYS94ZW4vYXJjaC94ODYv bW0vZ3Vlc3Rfd2Fsay5jCj4+Pj4+PiArKysgYi94ZW4vYXJjaC94ODYvbW0vZ3Vlc3Rfd2Fsay5j Cj4+Pj4+PiBAQCAtMTE0LDIyICsxMTQsMTggQEAgZ3Vlc3Rfd2Fsa190YWJsZXMoc3RydWN0IHZj cHUgKnYsIHN0cnVjdCBwMm1fZG9tYWluIAo+PiAqcDJtLAo+Pj4+Pj4gICAgICBBU1NFUlQoISh3 YWxrICYgUEZFQ19pbXBsaWNpdCkgfHwKPj4+Pj4+ICAgICAgICAgICAgICEod2FsayAmIChQRkVD X2luc25fZmV0Y2ggfCBQRkVDX3VzZXJfbW9kZSkpKTsKPj4+Pj4+ICAKPj4+Pj4+IC0gICAgLyoK Pj4+Pj4+IC0gICAgICogUEZFQ19pbnNuX2ZldGNoIGlzIG9ubHkgdXNlZCBhcyBhbiBpbnB1dCB0 byBwYWdldGFibGUgd2Fsa2luZyBpZiBOWCAKPj4gb3IKPj4+Pj4+IC0gICAgICogU01FUCBhcmUg ZW5hYmxlZC4gIE90aGVyd2lzZSwgaW5zdHJ1Y3Rpb24gZmV0Y2hlcyBhcmUgCj4+IGluZGlzdGlu Z3Vpc2hhYmxlCj4+Pj4+PiAtICAgICAqIGZyb20gZGF0YSByZWFkcy4KPj4+Pj4+IC0gICAgICoK Pj4+Pj4+IC0gICAgICogVGhpcyBwcm9wZXJ0eSBjYW4gYmUgZGVtb25zdHJhdGVkIG9uIHJlYWwg aGFyZHdhcmUgYnkgaGF2aW5nIE5YIGFuZAo+Pj4+Pj4gLSAgICAgKiBTTUVQIGluYWN0aXZlLCBi dXQgU01BUCBhY3RpdmUsIGFuZCBvYnNlcnZpbmcgdGhhdCBFRkxBR1MuQUMgCj4+IGRldGVybWlu ZXMKPj4+Pj4+IC0gICAgICogd2hldGhlciBhIHBhZ2VmYXVsdCBvY2N1cmVzIGZvciBzdXBlcnZp c29yIGV4ZWN1dGlvbiBvbiB1c2VyIAo+PiBtYXBwaW5ncy4KPj4+Pj4+IC0gICAgICovCj4+Pj4+ PiAtICAgIGlmICggIShndWVzdF9ueF9lbmFibGVkKHYpIHx8IGd1ZXN0X3NtZXBfZW5hYmxlZCh2 KSkgKQo+Pj4+Pj4gLSAgICAgICAgd2FsayAmPSB+UEZFQ19pbnNuX2ZldGNoOwo+Pj4+Pj4gLQo+ Pj4+Pj4gICAgICBwZXJmY19pbmNyKGd1ZXN0X3dhbGspOwo+Pj4+Pj4gICAgICBtZW1zZXQoZ3cs IDAsIHNpemVvZigqZ3cpKTsKPj4+Pj4+ICAgICAgZ3ctPnZhID0gdmE7Cj4+Pj4+PiAtICAgIGd3 LT5wZmVjID0gd2FsayAmIChQRkVDX2luc25fZmV0Y2ggfCBQRkVDX3VzZXJfbW9kZSB8IFBGRUNf d3JpdGVfYWNjZXNzKTsKPj4+Pj4+ICsgICAgZ3ctPnBmZWMgPSB3YWxrICYgKFBGRUNfdXNlcl9t b2RlIHwgUEZFQ193cml0ZV9hY2Nlc3MpOwo+Pj4+Pj4gKwo+Pj4+Pj4gKyAgICAvKgo+Pj4+Pj4g KyAgICAgKiBQRkVDX2luc25fZmV0Y2ggaXMgb25seSByZXBvcnRlZCBpZiBOWCBvciBTTUVQIGFy ZSBlbmFibGVkLiAgCj4+IEhhcmR3YXJlCj4+Pj4+PiArICAgICAqIHN0aWxsIGRpc3Rpbmd1ZXNl cyBpbnN0cnVjdGlvbiBmZXRjaGVzIGR1cmluZyBkZXRlcm1pbmF0aW9uIG9mIAo+PiBhY2Nlc3MK Pj4+Pj4+ICsgICAgICogcmlnaHRzLgo+Pj4+Pj4gKyAgICAgKi8KPj4+Pj4+ICsgICAgaWYgKCBn dWVzdF9ueF9lbmFibGVkKHYpIHx8IGd1ZXN0X3NtZXBfZW5hYmxlZCh2KSApCj4+Pj4+PiArICAg ICAgICBndy0+cGZlYyB8PSAod2FsayAmIFBGRUNfaW5zbl9mZXRjaCk7Cj4+Pj4+PiAgCj4+Pj4+ PiAgI2lmIEdVRVNUX1BBR0lOR19MRVZFTFMgPj0gMyAvKiBQQUUgb3IgNjQuLi4gKi8KPj4+Pj4+ ICAjaWYgR1VFU1RfUEFHSU5HX0xFVkVMUyA+PSA0IC8qIDY0LWJpdCBvbmx5Li4uICovCj4+Pj4+ IERvbid0IHlvdSBhbm90aGVyIGFkanVzdG1lbnQgdG8KPj4+Pj4KPj4+Pj4gICAgIGlmICggKHdh bGsgJiBQRkVDX2luc25fZmV0Y2gpICYmIChhciAmIF9QQUdFX05YX0JJVCkgKQo+Pj4+PiAgICAg ICAgIC8qIFJlcXVlc3RlZCBhbiBpbnN0cnVjdGlvbiBmZXRjaCBhbmQgZm91bmQgTlg/IEZhaWwu ICovCj4+Pj4+ICAgICAgICAgZ290byBvdXQ7Cj4+Pj4+Cj4+Pj4+IEkgY2FuJ3Qgc2VlIGFueXRo aW5nIHRoYXQgd291bGQga2VlcCBfUEFHRV9OWF9CSVQgb3V0IG9mCj4+Pj4+IGFyIGlmIE5YIGlz IG5vdCBlbmFibGVkLgo+Pj4+IF9QQUdFX05YX0JJVCBpcyByZXNlcnZlZCBpZiBOWCBpcyBub3Qg ZW5hYmxlZCwgYW5kIGlzIGFjY291bnRlZCBmb3IgaW4KPj4+PiBndWVzdF9yc3ZkX2JpdHMoKSBp biBndWVzdF9wdC5oLCBhbmQgd2UgbmV2ZXIgaGl0IHRoZSBhY2Nlc3MgcmlnaHRzIGxvZ2ljLgo+ Pj4gQWgsIHJpZ2h0LiBCdXQgcGVyaGFwcyB3b3J0aCBoYXZpbmcgYSByZXNwZWN0aXZlIEFTU0VS VCgpCj4+PiBoZXJlLCBhdCBvbmNlIHNlcnZpbmcgYXMgZG9jdW1lbnRhdGlvbj8KPj4gSSBjb3Vs ZCwgYnV0IGl0IHdvdWxkIGZlZWwgYmUgb3V0IG9mIHBsYWNlLiAgTlggYmVpbmcgaW5jb3JyZWN0 bHkgc2V0IGlzCj4+IGEgdHJhbnNsYXRpb24gZmFpbHVyZSwgYW5kIGJ5IGRlZmluaXRpb24sIHRo ZSB0cmFuc2xhdGlvbiBuZWVkcyB0byBoYXZlCj4+IHN1Y2NlZWRlZCBiZWZvcmUgcGVybWlzc2lv bnMgZ2V0IGNvbnNpZGVyZWQuCj4+Cj4+IFdvdWxkIHRoaXMgY2xhcmlmaWNhdGlvbiBiZSBhY2Nl cHRhYmxlPwo+Pgo+PiBpbmRleCA1YzZhODViLi42ZDZiNDU0IDEwMDY0NAo+PiAtLS0gYS94ZW4v YXJjaC94ODYvbW0vZ3Vlc3Rfd2Fsay5jCj4+ICsrKyBiL3hlbi9hcmNoL3g4Ni9tbS9ndWVzdF93 YWxrLmMKPj4gQEAgLTM2MCw4ICszNjAsOSBAQCBndWVzdF93YWxrX3RhYmxlcyhzdHJ1Y3QgdmNw dSAqdiwgc3RydWN0IHAybV9kb21haW4gKnAybSwKPj4gICAgICBndy0+cGZlYyB8PSBQRkVDX3Bh Z2VfcHJlc2VudDsKPj4gIAo+PiAgICAgIC8qCj4+IC0gICAgICogVGhlIHBhZ2V0YWJsZSB3YWxr IGhhcyByZXR1cm5lZCBhIHN1Y2Nlc3NmdWwgdHJhbnNsYXRpb24uICBOb3cgY2hlY2sKPj4gLSAg ICAgKiBhY2Nlc3MgcmlnaHRzIHRvIHNlZSB3aGV0aGVyIHRoZSBhY2Nlc3Mgc2hvdWxkIHN1Y2Nl ZWQuCj4+ICsgICAgICogVGhlIHBhZ2V0YWJsZSB3YWxrIGhhcyByZXR1cm5lZCBhIHN1Y2Nlc3Nm dWwgdHJhbnNsYXRpb24gKGkuZS4gQWxsCj4+ICsgICAgICogUFRFcyBhcmUgcHJlc2VudCBhbmQg aGF2ZSBubyByZXNlcnZlZCBiaXRzIHNldCkuICBOb3cgY2hlY2sgYWNjZXNzCj4+ICsgICAgICog cmlnaHRzIHRvIHNlZSB3aGV0aGVyIHRoZSBhY2Nlc3Mgc2hvdWxkIHN1Y2NlZWQuCj4+ICAgICAg ICovCj4gV2hpbGUgdGhpcyBwZXJoYXBzIGlzIGEgd29ydGh3aGlsZSBhZGRpdGlvbiwgbXkgb3Jp Z2luYWwgcmVxdWVzdAo+IHJlYWxseSB3YXMgdG8gbWFrZSBtb3JlIHZpc2libGUgYXJvdW5kIHRo ZSBwbGFjZSB3aGVyZSBpdCBtYXR0ZXJzCj4gdGhhdCB0aGUgTlggYml0IGlzIHBhcnQgb2YgdGhl IHJlc2VydmVkIG9uZXMgd2hlbiBOWCBpcyBvZmYuIEhlbmNlCj4gSSdtIG5vdCBzdXJlIHRoZSBj b21tZW50IGNoYW5nZSBpcyB3b3J0aHdoaWxlLCBhbmQgaWYgeW91IGRpc2xpa2UKPiBhZGRpbmcg dGhlIHN1Z2dlc3RlZCBBU1NFUlQoKSBJIHdvbid0IHRoZSBwYXRjaCBiZSBsZWZ0IGFzIGlzLgoK SSBwcmVzdW1lIHlvdSBtZWFucyBzb21ldGhpbmcgbGlrZSB5b3Ugd29uJ3QgbWluZCBpZiB0aGUg cGF0Y2ggaXMgbGVmdAphcy1pcz8KCkhvdyBhYm91dCB0aGlzPwoKZGlmZiAtLWdpdCBhL3hlbi9h cmNoL3g4Ni9tbS9ndWVzdF93YWxrLmMgYi94ZW4vYXJjaC94ODYvbW0vZ3Vlc3Rfd2Fsay5jCmlu ZGV4IDk3MjM2NGYuLjYwNTVmZWMgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9tbS9ndWVzdF93 YWxrLmMKKysrIGIveGVuL2FyY2gveDg2L21tL2d1ZXN0X3dhbGsuYwpAQCAtMzU2LDExICszNTYs MTkgQEAgZ3Vlc3Rfd2Fsa190YWJsZXMoc3RydWN0IHZjcHUgKnYsIHN0cnVjdApwMm1fZG9tYWlu ICpwMm0sCiAgICAgZ3ctPnBmZWMgfD0gUEZFQ19wYWdlX3ByZXNlbnQ7CiAKICAgICAvKgotICAg ICAqIFRoZSBwYWdldGFibGUgd2FsayBoYXMgcmV0dXJuZWQgYSBzdWNjZXNzZnVsIHRyYW5zbGF0 aW9uLiAgTm93IGNoZWNrCi0gICAgICogYWNjZXNzIHJpZ2h0cyB0byBzZWUgd2hldGhlciB0aGUg YWNjZXNzIHNob3VsZCBzdWNjZWVkLgorICAgICAqIFRoZSBwYWdldGFibGUgd2FsayBoYXMgcmV0 dXJuZWQgYSBzdWNjZXNzZnVsIHRyYW5zbGF0aW9uIChpLmUuCkFsbCBQVEVzCisgICAgICogYXJl IHByZXNlbnQgYW5kIGhhdmUgbm8gcmVzZXJ2ZWQgYml0cyBzZXQpLiAgTm93IGNoZWNrIGFjY2Vz cwpyaWdodHMgdG8KKyAgICAgKiBzZWUgd2hldGhlciB0aGUgYWNjZXNzIHNob3VsZCBzdWNjZWVk LgogICAgICAqLwogICAgIGFyID0gKGFyX2FuZCAmIEFSX0FDQ1VNX0FORCkgfCAoYXJfb3IgJiBB Ul9BQ0NVTV9PUik7CiAKKyAgICAvKgorICAgICAqIFNhbml0eSBjaGVjay4gIElmIEVGRVIuTlgg aXMgZGlzYWJsZWQsIF9QQUdFX05YX0JJVCBpcyByZXNlcnZlZCBhbmQKKyAgICAgKiBzaG91bGQg aGF2ZSBjYXVzZWQgYSB0cmFuc2xhdGlvbiBmYWlsdXJlIGJlZm9yZSB3ZSBnZXQgaGVyZS4KKyAg ICAgKi8KKyAgICBpZiAoIGFyICYgX1BBR0VfTlhfQklUICkKKyAgICAgICAgQVNTRVJUKGd1ZXN0 X254X2VuYWJsZWQodikpOworCiAjaWYgR1VFU1RfUEFHSU5HX0xFVkVMUyA+PSA0IC8qIDY0LWJp dCBvbmx5Li4uICovCiAgICAgLyoKICAgICAgKiBJZiBhbGwgYWNjZXNzIGNoZWNrcyBhcmUgdGh1 cyBmYXIgb2ssIGNoZWNrIFByb3RlY3Rpb24gS2V5IGZvciA2NGJpdAoKCk9uZSBwcm9ibGVtIEkg aGF2ZSB3aXRoIGFuIEFTU0VSVCBiZXNpZGUgdGhlICJpZiAoICh3YWxrICYKUEZFQ19pbnNuX2Zl dGNoKSAmJiAoYXIgJiBfUEFHRV9OWF9CSVQpICkiIGlzIHRoYXQgaXQgaXMgbWlkLXdheSB0aHJv dWdoCnRoZSBwZXJtaXNzaW9ucyBjaGVja3MsIHJhdGhlciB0aGFuIGF0IHRoZSBzdGFydCwgd2hp Y2ggaXMgbGlrZWx5IHRvIGdldAptaXNzZWQgaWYgZnV0dXJlIGFjY2VzcyBjaGVja3MgZ2V0IGlu dHJvZHVjZWQgYWhlYWQgb2YgdGhlIHByb3RlY3Rpb24Ka2V5IGNoZWNrcy4KCn5BbmRyZXcKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBt YWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3Jn L3hlbi1kZXZlbAo=