From: Paul Durrant <Paul.Durrant@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Ian Jackson <Ian.Jackson@citrix.com>,
"Tim (Xen.org)" <tim@xen.org>, "Keir (Xen.org)" <keir@xen.org>,
Ian Campbell <Ian.Campbell@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3] public/io/netif.h: make control ring hash protocol more general
Date: Wed, 17 Feb 2016 10:01:06 +0000 [thread overview]
Message-ID: <063a25eabaf54d1dbca1affaeb494a2d@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <56C450E602000078000D2FB5@prv-mh.provo.novell.com>
> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: 17 February 2016 09:52
> To: Paul Durrant
> Cc: Ian Campbell; Ian Jackson; xen-devel@lists.xenproject.org; Keir
> (Xen.org); Tim (Xen.org)
> Subject: Re: [PATCH v3] public/io/netif.h: make control ring hash protocol
> more general
>
> >>> On 16.02.16 at 16:00, <paul.durrant@citrix.com> wrote:
> > v3:
> > - Use XEN_NETIF_ prefix instead of NETIF_
>
> Stale patch? Because I can't see this having happened ...
>
> > @@ -206,10 +206,10 @@
> > * Buffer[0..8] = Packet[12..15] (source address) +
> > * Packet[16..19] (destination address)
> > *
> > - * Result = ToeplitzHash(Buffer, 8)
> > + * Result = Hash(Buffer, 8)
> > */
> > -#define _NETIF_CTRL_TOEPLITZ_HASH_IPV4 0
> > -#define NETIF_CTRL_TOEPLITZ_HASH_IPV4 (1 <<
> _NETIF_CTRL_TOEPLITZ_HASH_IPV4)
> > +#define _NETIF_CTRL_HASH_TYPE_IPV4 0
> > +#define NETIF_CTRL_HASH_TYPE_IPV4 (1 <<
> _NETIF_CTRL_HASH_TYPE_IPV4)
>
> ... here as well as further down.
>
Damn. Missing 'git add' before commit. I'll post v4.
Paul
> Jan
prev parent reply other threads:[~2016-02-17 10:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 15:00 [PATCH v3] public/io/netif.h: make control ring hash protocol more general Paul Durrant
2016-02-17 9:52 ` Jan Beulich
2016-02-17 10:01 ` Paul Durrant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=063a25eabaf54d1dbca1affaeb494a2d@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).