From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul Durrant <Paul.Durrant@citrix.com>
Subject: Re: [PATCH v3] public/io/netif.h: make control ring
 hash protocol more general
Date: Wed, 17 Feb 2016 10:01:06 +0000
Message-ID: <063a25eabaf54d1dbca1affaeb494a2d@AMSPEX02CL03.citrite.net>
References: <1455634846-1735-1-git-send-email-paul.durrant@citrix.com>
	<56C450E602000078000D2FB5@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=84824ace7=Paul.Durrant@citrix.com>)
	id 1aVywx-0001ux-KP
	for xen-devel@lists.xenproject.org; Wed, 17 Feb 2016 10:03:11 +0000
In-Reply-To: <56C450E602000078000D2FB5@prv-mh.provo.novell.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Ian Jackson <Ian.Jackson@citrix.com>, "Tim
	(Xen.org)" <tim@xen.org>, "Keir (Xen.org)" <keir@xen.org>, Ian Campbell <Ian.Campbell@citrix.com>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: 17 February 2016 09:52
> To: Paul Durrant
> Cc: Ian Campbell; Ian Jackson; xen-devel@lists.xenproject.org; Keir
> (Xen.org); Tim (Xen.org)
> Subject: Re: [PATCH v3] public/io/netif.h: make control ring hash protocol
> more general
> 
> >>> On 16.02.16 at 16:00, <paul.durrant@citrix.com> wrote:
> > v3:
> >   - Use XEN_NETIF_ prefix instead of NETIF_
> 
> Stale patch? Because I can't see this having happened ...
> 
> > @@ -206,10 +206,10 @@
> >   * Buffer[0..8] = Packet[12..15] (source address) +
> >   *                Packet[16..19] (destination address)
> >   *
> > - * Result = ToeplitzHash(Buffer, 8)
> > + * Result = Hash(Buffer, 8)
> >   */
> > -#define _NETIF_CTRL_TOEPLITZ_HASH_IPV4     0
> > -#define NETIF_CTRL_TOEPLITZ_HASH_IPV4      (1 <<
> _NETIF_CTRL_TOEPLITZ_HASH_IPV4)
> > +#define _NETIF_CTRL_HASH_TYPE_IPV4 0
> > +#define NETIF_CTRL_HASH_TYPE_IPV4 (1 <<
> _NETIF_CTRL_HASH_TYPE_IPV4)
> 
> ... here as well as further down.
> 

Damn. Missing 'git add' before commit. I'll post v4.

  Paul

> Jan