From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xensource.com
Cc: Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH 3 of 9] libxl: move various enum and #defines above datastructure definitions
Date: Fri, 13 Aug 2010 14:50:06 +0100 [thread overview]
Message-ID: <06e63fc8240a8d590208.1281707406@localhost.localdomain> (raw)
In-Reply-To: <patchbomb.1281707403@localhost.localdomain>
# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1281706573 -3600
# Node ID 06e63fc8240a8d5902087947e016b7f69ab53071
# Parent bee7f853a66535787786e99f5eba951717cea0ac
libxl: move various enum and #defines above datastructure definitions.
These are left behind when the datastructures move to _lixl_types.hg
in a following patch and moving them first makes that pure code motion
patch more obviously correct.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
diff -r bee7f853a665 -r 06e63fc8240a tools/libxl/libxl.h
--- a/tools/libxl/libxl.h Fri Aug 13 14:36:13 2010 +0100
+++ b/tools/libxl/libxl.h Fri Aug 13 14:36:13 2010 +0100
@@ -29,6 +29,32 @@ typedef char **libxl_string_list;
typedef char **libxl_string_list;
typedef char **libxl_key_value_list;
+
+typedef enum {
+ XENFV = 1,
+ XENPV,
+} libxl_qemu_machine_type;
+
+typedef enum {
+ CONSTYPE_XENCONSOLED,
+ CONSTYPE_IOEMU,
+} libxl_console_constype;
+
+typedef enum {
+ PHYSTYPE_QCOW = 1,
+ PHYSTYPE_QCOW2,
+ PHYSTYPE_VHD,
+ PHYSTYPE_AIO,
+ PHYSTYPE_FILE,
+ PHYSTYPE_PHY,
+} libxl_disk_phystype;
+
+typedef enum {
+ NICTYPE_IOEMU = 1,
+ NICTYPE_VIF,
+} libxl_nic_type;
+
+#define LIBXL_PCI_FUNC_ALL (~0U)
typedef struct {
libxl_uuid uuid;
@@ -170,11 +196,6 @@ typedef struct {
int (*suspend_callback)(void *, int);
} libxl_domain_suspend_info;
-typedef enum {
- XENFV = 1,
- XENPV,
-} libxl_qemu_machine_type;
-
typedef struct {
int domid;
libxl_uuid uuid; /* this is use only with stubdom, and must be different from the domain uuid */
@@ -228,11 +249,6 @@ typedef struct {
int devid;
} libxl_device_vkb;
-typedef enum {
- CONSTYPE_XENCONSOLED,
- CONSTYPE_IOEMU,
-} libxl_console_constype;
-
typedef struct {
uint32_t backend_domid;
uint32_t domid;
@@ -240,15 +256,6 @@ typedef struct {
libxl_console_constype constype;
libxl_domain_build_state *build_state;
} libxl_device_console;
-
-typedef enum {
- PHYSTYPE_QCOW = 1,
- PHYSTYPE_QCOW2,
- PHYSTYPE_VHD,
- PHYSTYPE_AIO,
- PHYSTYPE_FILE,
- PHYSTYPE_PHY,
-} libxl_disk_phystype;
typedef struct {
uint32_t backend_domid;
@@ -260,11 +267,6 @@ typedef struct {
int readwrite;
int is_cdrom;
} libxl_device_disk;
-
-typedef enum {
- NICTYPE_IOEMU = 1,
- NICTYPE_VIF,
-} libxl_nic_type;
typedef struct {
uint32_t backend_domid;
@@ -310,7 +312,6 @@ typedef struct {
};
unsigned int domain;
unsigned int vdevfn;
-#define LIBXL_PCI_FUNC_ALL (~0U)
unsigned int vfunc_mask;
bool msitranslate;
bool power_mgmt;
next prev parent reply other threads:[~2010-08-13 13:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-13 13:50 [PATCH 0 of 9] libxl: autogenerate type definitions and destructor functions Ian Campbell
2010-08-13 13:50 ` [PATCH 1 of 9] xl: use the regular implicit rules to build the xl .o files Ian Campbell
2010-08-13 13:50 ` [PATCH 2 of 9] libxl: define specific types for string list and key, value list Ian Campbell
2010-08-13 13:50 ` Ian Campbell [this message]
2010-08-13 13:50 ` [PATCH 4 of 9] libxl: ensure result of libxl_poolid_to_name is always dynamically allocated Ian Campbell
2010-08-13 13:50 ` [PATCH 5 of 9] libxl: move type definitions into _libxl_types.h Ian Campbell
2010-08-13 13:50 ` [PATCH 6 of 9] libxl: tweak formatting/whitespace of _libxl_types.h Ian Campbell
2010-08-13 13:50 ` [PATCH 7 of 9] libxl: autogenerate _libxl_types.h Ian Campbell
2010-08-13 13:50 ` [PATCH 8 of 9] libxl: generate destructors for each libxl defined type Ian Campbell
2010-08-13 13:50 ` [PATCH 9 of 9] xl: free the libxl types contained in struct domain_config Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06e63fc8240a8d590208.1281707406@localhost.localdomain \
--to=ian.campbell@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).