Re: [PATCH 1 of 3] IOMMU: Add command line param to disable sharing of IOMMU and hap tables

["Andres Lagar-Cavilla" <andres@lagarcavilla.org>]

> At 10:57 +0000 on 22 Mar (1332413830), Jan Beulich wrote:
>> >          if ( !parse_bool(s) )
>> > -            iommu_enabled = 0;
>> > +            iommu_enabled = val;
>>
>> ... this one must remain unchanged, and the handling of the "no-"
>> prefix should come afterwards.
>
> Meh.  I reserve the right to set 'iommu=no-yes'. :)
> That is to say, I don't think it makes any real difference.

Well, it'd be great if one version or the other goes in before 4.2 closes :)
Thanks
Andres

>
> Tim.
>
>> >          else if ( !strcmp(s, "force") || !strcmp(s, "required") )
>> > -            force_iommu = 1;
>> > +            force_iommu = val;
>> >          else if ( !strcmp(s, "workaround_bios_bug") )
>> >              iommu_workaround_bios_bug = 1;
>> >          else if ( !strcmp(s, "verbose") )
>> > -            iommu_verbose = 1;
>> > -        else if ( !strcmp(s, "no-snoop") )
>> > -            iommu_snoop = 0;
>> > -        else if ( !strcmp(s, "no-qinval") )
>> > -            iommu_qinval = 0;
>> > -        else if ( !strcmp(s, "no-intremap") )
>> > -            iommu_intremap = 0;
>> > +            iommu_verbose = val;
>> > +        else if ( !strcmp(s, "snoop") )
>> > +            iommu_snoop = val;
>> > +        else if ( !strcmp(s, "qinval") )
>> > +            iommu_qinval = val;
>> > +        else if ( !strcmp(s, "intremap") )
>> > +            iommu_intremap = val;
>> >          else if ( !strcmp(s, "debug") )
>> > -            iommu_debug = 1;
>> > +            iommu_debug = val;
>> >          else if ( !strcmp(s, "amd-iommu-perdev-intremap") )
>> > -            amd_iommu_perdev_intremap = 1;
>> > +            amd_iommu_perdev_intremap = val;
>> >          else if ( !strcmp(s, "dom0-passthrough") )
>> > -            iommu_passthrough = 1;
>> > +            iommu_passthrough = val;
>> >          else if ( !strcmp(s, "dom0-strict") )
>> > -            iommu_dom0_strict = 1;
>> > +            iommu_dom0_strict = val;
>> >          else if ( !strcmp(s, "sharept") )
>> > -            iommu_hap_pt_share = 1;
>> > +            iommu_hap_pt_share = val;
>> >
>> >          s = ss + 1;
>> >      } while ( ss );
>>
>>
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> http://lists.xen.org/xen-devel
>