From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 3/9] x86/vvmx: Extract operand reading logic into operand_read() Date: Mon, 27 Nov 2017 18:08:07 +0000 Message-ID: <07b92a94-279d-24dd-fab8-980da55ec59e@citrix.com> References: <1509037399-48926-1-git-send-email-euan.harris@citrix.com> <1509037399-48926-4-git-send-email-euan.harris@citrix.com> <5A1C530D02000078001927B4@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJNpC-0004Zf-Rl for xen-devel@lists.xenproject.org; Mon, 27 Nov 2017 18:08:10 +0000 In-Reply-To: <5A1C530D02000078001927B4@prv-mh.provo.novell.com> Content-Language: en-GB List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Jan Beulich , Euan Harris Cc: xen-devel@lists.xenproject.org, kevin.tian@intel.com, jun.nakajima@intel.com List-Id: xen-devel@lists.xenproject.org T24gMjcvMTEvMTcgMTc6MDEsIEphbiBCZXVsaWNoIHdyb3RlOgo+Pj4+IE9uIDI2LjEwLjE3IGF0 IDE5OjAzLCA8ZXVhbi5oYXJyaXNAY2l0cml4LmNvbT4gd3JvdGU6Cj4+IC0tLSBhL3hlbi9hcmNo L3g4Ni9odm0vdm14L3Z2bXguYwo+PiArKysgYi94ZW4vYXJjaC94ODYvaHZtL3ZteC92dm14LmMK Pj4gQEAgLTM2MSw2ICszNjEsNDAgQEAgc3RhdGljIHZvaWQgcmVnX3dyaXRlKHN0cnVjdCBjcHVf dXNlcl9yZWdzICpyZWdzLAo+PiAgICAgICpwdmFsID0gdmFsdWU7Cj4+ICB9Cj4+ICAKPj4gK3N0 YXRpYyBpbnQgb3BlcmFuZF9yZWFkKHZvaWQgKmJ1Ziwgc3RydWN0IHZteF9pbnN0X29wICpvcCwK Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBjcHVfdXNlcl9yZWdzICpyZWdzLCB1 bnNpZ25lZCBpbnQgYnl0ZXMpCj4+ICt7Cj4+ICsgICAgaWYgKCBvcC0+dHlwZSA9PSBWTVhfSU5T VF9NRU1SRUdfVFlQRV9SRUcgKQo+PiArICAgIHsKPj4gKyAgICAgICAgc3dpdGNoICggYnl0ZXMg KQo+PiArICAgICAgICB7Cj4+ICsgICAgICAgIGNhc2UgNDoKPj4gKyAgICAgICAgICAgICoodWlu dDMyX3QgKilidWYgPSByZWdfcmVhZChyZWdzLCBvcC0+cmVnX2lkeCk7Cj4+ICsKPj4gKyAgICAg ICAgY2FzZSA4Ogo+PiArICAgICAgICAgICAgKih1aW50NjRfdCAqKWJ1ZiA9IHJlZ19yZWFkKHJl Z3MsIG9wLT5yZWdfaWR4KTsKPj4gKwo+PiArICAgICAgICBkZWZhdWx0Ogo+PiArICAgICAgICAg ICAgQVNTRVJUX1VOUkVBQ0hBQkxFKCk7Cj4+ICsgICAgICAgICAgICByZXR1cm4gWDg2RU1VTF9V TkhBTkRMRUFCTEU7Cj4+ICsgICAgICAgIH0KPiBMb29rcyBsaWtlIHRoZXJlIGFyZSB0d28gbWlz c2luZyBicmVhayBzdGF0ZW1lbnRzIHVwIHRoZXJlLgoKSSBmaXhlZCB0aGVzZSB1cCB4ODYtbmV4 dC7CoCAoQWx0aG91Z2ggaXQgd2FzIG9ubHkgYmVjYXVzZSBDb3Zlcml0eQpub3RpY2VkIGFuZCBj b21wbGFpbmVkIGF0IG1lLi4uKQoKPgo+PiArICAgICAgICByZXR1cm4gWDg2RU1VTF9PS0FZOwo+ IFRoaXMgYW5kIC4uLgo+Cj4+ICsgICAgfQo+PiArICAgIGVsc2UKPj4gKyAgICB7Cj4+ICsgICAg ICAgIHBhZ2VmYXVsdF9pbmZvX3QgcGZpbmZvOwo+PiArICAgICAgICBpbnQgcmMgPSBodm1fY29w eV9mcm9tX2d1ZXN0X2xpbmVhcihidWYsIG9wLT5tZW0sIGJ5dGVzLCAwLCAmcGZpbmZvKTsKPj4g Kwo+PiArICAgICAgICBpZiAoIHJjID09IEhWTVRSQU5TX2JhZF9saW5lYXJfdG9fZ2ZuICkKPj4g KyAgICAgICAgICAgIGh2bV9pbmplY3RfcGFnZV9mYXVsdChwZmluZm8uZWMsIHBmaW5mby5saW5l YXIpOwo+PiArICAgICAgICBpZiAoIHJjICE9IEhWTVRSQU5TX29rYXkgKQo+PiArICAgICAgICAg ICAgcmV0dXJuIFg4NkVNVUxfRVhDRVBUSU9OOwo+PiArCj4+ICsgICAgICAgIHJldHVybiBYODZF TVVMX09LQVk7Cj4gLi4uIHRoaXMgc2hvdWxkIGJlY29tZSBhIHVuaWZvcm0gLi4uCj4KPj4gKyAg ICB9Cj4gLi4uIHJldHVybiBoZXJlLgoKSSB0cmllZCB0aGlzLCBidXQgbGF0ZXIgcGF0Y2hlcyBp biB0aGUgc2VyaWVzIG5lZWQgdGhlbSB0byBtb3ZlIGJhY2suwqAKT3ZlcmFsbCwgdGhpcyBsYXlv dXQgcmVkdWNlcyB0aGUgY29kZSBjaHVybiBhY3Jvc3MgdGhlIHNlcmllcy4KCj4KPj4gQEAgLTQ0 MCw3ICs0NzQsMTIgQEAgc3RhdGljIGludCBkZWNvZGVfdm14X2luc3Qoc3RydWN0IGNwdV91c2Vy X3JlZ3MgKnJlZ3MsCj4+ICAgICAgICAgIGRlY29kZS0+b3BbMF0udHlwZSA9IFZNWF9JTlNUX01F TVJFR19UWVBFX1JFRzsKPj4gICAgICAgICAgZGVjb2RlLT5vcFswXS5yZWdfaWR4ID0gaW5mby5m aWVsZHMucmVnMTsKPj4gICAgICAgICAgaWYgKCBwb3BlcmFuZFMgIT0gTlVMTCApCj4+IC0gICAg ICAgICAgICAqcG9wZXJhbmRTID0gcmVnX3JlYWQocmVncywgZGVjb2RlLT5vcFswXS5yZWdfaWR4 KTsKPj4gKyAgICAgICAgewo+PiArICAgICAgICAgICAgaW50IHJjID0gb3BlcmFuZF9yZWFkKHBv cGVyYW5kUywgJmRlY29kZS0+b3BbMF0sIHJlZ3MsCj4+ICsgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgZGVjb2RlLT5vcFswXS5sZW4pOwo+PiArICAgICAgICAgICAgaWYgKCByYyAh PSBYODZFTVVMX09LQVkgKQo+IEJsYW5rIGxpbmUgYmV0d2VlbiBkZWNsYXJhdGlvbihzKSBhbmQg c3RhdGVtZW50KHMpIHBsZWFzZS4KCkkgY2FuIGZpeCB0aGlzLgoKfkFuZHJldwoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcg bGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9q ZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==