Re: [PATCH v3] x86/hvm/viridian: zero and check vcpu context __pad field

[Paul Durrant <Paul.Durrant@citrix.com>]

> -----Original Message-----
> From: Xen-devel [mailto:xen-devel-bounces@lists.xen.org] On Behalf Of Jan
> Beulich
> Sent: 30 March 2016 15:23
> To: Paul Durrant
> Cc: Andrew Cooper; Keir (Xen.org); xen-devel@lists.xenproject.org
> Subject: Re: [Xen-devel] [PATCH v3] x86/hvm/viridian: zero and check vcpu
> context __pad field
> 
> >>> On 30.03.16 at 15:18, <Paul.Durrant@citrix.com> wrote:
> >>  -----Original Message-----
> >> From: Jan Beulich [mailto:JBeulich@suse.com]
> >> Sent: 30 March 2016 14:15
> >> To: Paul Durrant
> >> Cc: Andrew Cooper; xen-devel@lists.xenproject.org; Keir (Xen.org)
> >> Subject: Re: [PATCH v3] x86/hvm/viridian: zero and check vcpu context
> >> __pad field
> >>
> >> >>> On 30.03.16 at 13:34, <paul.durrant@citrix.com> wrote:
> >> > --- a/xen/arch/x86/mm.c
> >> > +++ b/xen/arch/x86/mm.c
> >> > @@ -589,7 +589,8 @@ static inline void guest_get_eff_kern_l1e(struct
> >> vcpu *v, unsigned long addr,
> >> >      TOGGLE_MODE();
> >> >  }
> >> >
> >> > -static const char __section(".bss.page_aligned.const")
> >> zero_page[PAGE_SIZE];
> >> > +static const char __section(".bss.page_aligned.const")
> >> __zero_page[PAGE_SIZE];
> >> > +const char *zero_page = __zero_page;
> >>
> >> Mind explaining why simply dropping the "static" doesn't do what we
> >> want?
> >>
> >
> > That's what I did first. I got:
> >
> > mm.c:592:56: error: conflicting types for âzero_pageâ
> >  static const char __section(".bss.page_aligned.const")
> > zero_page[PAGE_SIZE];
> >                                                         ^
> > In file included from
> /local/scratch/pauldu/xen/xen/include/xen/mm.h:195:0,
> >                  from mm.c:90:
> > /local/scratch/pauldu/xen/xen/include/asm/mm.h:598:20: note: previous
> > declaration of âzero_pageâ was here
> >  extern const char *zero_page;
> >                     ^
> > /local/scratch/pauldu/xen/xen/Rules.mk:166: recipe for target 'mm.o'
> failed
> 
> Obviously this can't work: You meant
> 
> extern const char zero_page[];
> 

Yes, I guess I did.

  Paul

> Jan
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel