From: Eric Blake <eblake@redhat.com>
To: Paul Durrant <Paul.Durrant@citrix.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"famz@redhat.com" <famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] xen-hvm: use new resource mapping API
Date: Wed, 9 May 2018 12:26:06 -0500 [thread overview]
Message-ID: <0c96c8b0-4736-d1fe-8145-bf14d2a24a97@redhat.com> (raw)
In-Reply-To: <82906d30c1854e13bd7986af99eb1d98@AMSPEX02CL03.citrite.net>
On 05/09/2018 11:05 AM, Paul Durrant wrote:
>> xenforeignmemory_map_resource() to map ioreq pages...
>> ERROR: spaces required around that '*' (ctx:WxV)
>> #164: FILE: include/hw/xen/xen_common.h:128:
>> + xenforeignmemory_handle *fmem, domid_t domid, unsigned int type,
>> ^
>>
>> total: 1 errors, 0 warnings, 138 lines checked
>>
>> Your patch has style problems, please review. If any of these errors
>> are false positives report them to the maintainer, see
>> CHECKPATCH in MAINTAINERS.
>
> This style warning appears to be spurious.
Yep, and it's because xenforeignmemory_handle doesn't follow our usual
conventions for a type name. See commit 5ac067a if you want to add it
to the list of whitelisted exception type names, to silence messages
like this.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-05-09 17:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 15:46 [PATCH 0/2] xen-hvm: use new resource mapping API Paul Durrant
2018-05-09 15:46 ` [PATCH 1/2] xen-hvm: create separate function for ioreq server initialization Paul Durrant
2018-05-09 15:46 ` [PATCH 2/2] xen-hvm: try to use xenforeignmemory_map_resource() to map ioreq pages Paul Durrant
2018-05-09 16:01 ` [Qemu-devel] [PATCH 0/2] xen-hvm: use new resource mapping API no-reply
2018-05-09 16:05 ` Paul Durrant
2018-05-09 17:26 ` Eric Blake [this message]
2018-05-10 8:29 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c96c8b0-4736-d1fe-8145-bf14d2a24a97@redhat.com \
--to=eblake@redhat.com \
--cc=Paul.Durrant@citrix.com \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).