Re: [PATCH] tools/libxenforeignmemory: add a call to restrict the handle

[Paul Durrant <Paul.Durrant@citrix.com>]

> -----Original Message-----
> From: Andrew Cooper
> Sent: 24 March 2017 20:10
> To: Paul Durrant <Paul.Durrant@citrix.com>; xen-devel@lists.xenproject.org
> Cc: Wei Liu <wei.liu2@citrix.com>; Ian Jackson <Ian.Jackson@citrix.com>;
> Julien Grall <julien.grall@arm.com>
> Subject: Re: [Xen-devel] [PATCH] tools/libxenforeignmemory: add a call to
> restrict the handle
> 
> On 22/03/17 11:25, Paul Durrant wrote:
> > diff --git a/tools/libs/foreignmemory/libxenforeignmemory.map
> b/tools/libs/foreignmemory/libxenforeignmemory.map
> > index df206b3..5c9806c 100644
> > --- a/tools/libs/foreignmemory/libxenforeignmemory.map
> > +++ b/tools/libs/foreignmemory/libxenforeignmemory.map
> > @@ -4,5 +4,6 @@ VERS_1.0 {
> >  		xenforeignmemory_close;
> >  		xenforeignmemory_map;
> >  		xenforeignmemory_unmap;
> > +		xenforeignmemory_restrict;
> >  	local: *; /* Do not expose anything by default */
> >  };
> 
> This isn't correct.
> 
> New functions like this need to bump at least the SO minor version, like
> c/s f1446de4ba
> 

Sorry, yes, I forgot these libraries are supposed to be stable now.

> Fixing this is a blocker to releasing 4.9
> 

I'll submit a patch on Monday.

> Also, we should really get automatic ABI checking built into the release
> process, to prevent mistakes like this from happening accidentally.
> 

Yes, definitely.

  Paul

> ~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel