xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: xen-devel@lists.xensource.com
Cc: Roger Pau Monne <roger.pau@citrix.com>
Subject: [PATCH 1 of 3] tools/configure.ac: add version check for glib2
Date: Wed, 13 Jun 2012 15:10:48 +0200	[thread overview]
Message-ID: <0dfe08c91739527eb454.1339593048@probook.site> (raw)
In-Reply-To: <patchbomb.1339593047@probook.site>

# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1339593000 -7200
# Node ID 0dfe08c91739527eb454d5e4957635cb8b90e1e1
# Parent  a70b35deb2b5592cc1b2363860f21bb2c7049885
tools/configure.ac: add version check for glib2

xen-unstable fails to build in a SLES10SP4 environment since a long time
because the included version of glib is slightly older than the required
glib version. According to the glib docs version 2.12 includes base64
support, but SLES10 is shipped with glib 2.8.6:

qemu-timer-common.o: In function `init_get_clock':
/usr/src/packages/BUILD/xen-4.2.25432/non-dbg/tools/qemu-xen-dir/qemu-timer-common.c:57:
undefined reference to `clock_gettime'
qga/guest-agent-commands.o: In function `qmp_guest_file_write':
qga/guest-agent-commands.c:249: undefined reference to `g_base64_decode'
qga/guest-agent-commands.o: In function `qmp_guest_file_read':
qga/guest-agent-commands.c:224: undefined reference to `g_base64_encode'
collect2: ld returned 1 exit status
make[3]: *** [qemu-ga] Error 1

Add a version check to toplevel configure to require at least glib 2.12.
This makes sure configure can detect the condition early instead of
failing later in the middle of tools build when qemu-upstream errors
out.

Please rerun autoconf after applying this.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>

diff -r a70b35deb2b5 -r 0dfe08c91739 tools/configure.ac
--- a/tools/configure.ac
+++ b/tools/configure.ac
@@ -115,7 +115,7 @@ AX_PATH_PROG_OR_FAIL([BCC], [bcc])
 AX_PATH_PROG_OR_FAIL([IASL], [iasl])
 AX_CHECK_UUID
 AX_CHECK_CURSES
-PKG_CHECK_MODULES(glib, glib-2.0)
+PKG_CHECK_MODULES(glib, [glib-2.0 >= 2.12])
 
 # Check library path
 AX_DEFAULT_LIB
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2012-06-13 13:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-13 13:10 [PATCH 0 of 3] [v2] tools/configure.ac changes Olaf Hering
2012-06-13 13:10 ` Olaf Hering [this message]
2012-06-26 16:16   ` [PATCH 1 of 3] tools/configure.ac: add version check for glib2 Ian Campbell
2012-06-13 13:10 ` [PATCH 2 of 3] tools/m4: add AC_LANG_SOURCE to fix autoconf warnings Olaf Hering
2012-06-26 16:16   ` Ian Campbell
2012-07-04 13:34   ` Ian Campbell
2012-07-04 13:39     ` Olaf Hering
2012-07-04 13:54       ` Ian Campbell
2012-06-13 13:10 ` [PATCH 3 of 3] tools/configure.ac: fill PACKAGE_TARNAME in AC_INIT Olaf Hering
2012-06-26 16:17   ` Ian Campbell
2012-07-04 14:47 ` [PATCH 0 of 3] [v2] tools/configure.ac changes Ian Campbell
2012-07-04 14:52   ` Olaf Hering
2012-07-04 15:17     ` Ian Campbell
  -- strict thread matches above, loose matches on Subject: below --
2012-06-13  8:01 [PATCH 0 of 3] " Olaf Hering
2012-06-13  8:01 ` [PATCH 1 of 3] tools/configure.ac: add version check for glib2 Olaf Hering
2012-06-13  8:14   ` Ian Campbell
2012-06-13  8:56     ` Roger Pau Monne
2012-06-13  8:58       ` Ian Campbell
2012-06-13  9:01         ` Roger Pau Monne
2012-06-13  9:41           ` Ian Campbell
2012-06-13 12:54     ` Olaf Hering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0dfe08c91739527eb454.1339593048@probook.site \
    --to=olaf@aepfle.de \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).