From: George Dunlap <george.dunlap@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: george.dunlap@eu.citrix.com
Subject: [PATCH 6 of 8] xenalyze: Eliminate unnecessary cycles_to_time calculation
Date: Thu, 26 Jan 2012 17:21:03 +0000 [thread overview]
Message-ID: <108d0235440318d51a33.1327598463@elijah> (raw)
In-Reply-To: <patchbomb.1327598457@elijah>
The time elements are only really accessed in dump mode, but they
cost a significant amount to calculate per record. Only calculate
them if we're in dump mode.
Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
diff -r 4b3639bd3255 -r 108d02354403 xenalyze.c
--- a/xenalyze.c Thu Jan 26 17:17:19 2012 +0000
+++ b/xenalyze.c Thu Jan 26 17:17:53 2012 +0000
@@ -8601,9 +8601,6 @@ void process_record_tsc(tsc_t order_tsc,
P.now = tsc;
}
-
- /* Convert to s/ns once for convenience */
- abs_cycles_to_time(ri->tsc, &ri->t);
}
/* Standardized part of dump output */
@@ -8615,6 +8612,8 @@ void create_dump_header(struct record_in
len = DUMP_HEADER_MAX;
c = ri->dump_header;
+ abs_cycles_to_time(ri->tsc, &ri->t);
+
if ( ri->t.time )
{
r=snprintf(c, len, "%3u.%09u", ri->t.s, ri->t.ns);
next prev parent reply other threads:[~2012-01-26 17:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 17:20 [PATCH 0 of 8] xenalyze: Optimizations George Dunlap
2012-01-26 17:20 ` [PATCH 1 of 8] xenalyze: Improve record-sorting algorithm George Dunlap
2012-01-26 17:20 ` [PATCH 2 of 8] xenalyze: Remove spurious dump_header construction George Dunlap
2012-01-26 17:21 ` [PATCH 3 of 8] xenalyze: Remove --dump-cooked George Dunlap
2012-01-26 17:21 ` [PATCH 4 of 8] xenalyze: Enable -O2 optimization level George Dunlap
2012-01-26 17:21 ` [PATCH 5 of 8] xenalyze: Rework math to remove two 64-bit divisions George Dunlap
2012-01-26 17:21 ` George Dunlap [this message]
2012-01-26 17:21 ` [PATCH 7 of 8] xenalyze: Introduce more efficient read mechanism George Dunlap
2012-01-26 17:21 ` [PATCH 8 of 8] xenalyze: Get rid of redundant hvm dump_header George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=108d0235440318d51a33.1327598463@elijah \
--to=george.dunlap@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).