From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: Re: [PATCH] ia64 build fixes Date: Sun, 02 Apr 2006 09:37:19 +0100 Message-ID: <1143967039.4547.5.camel@localhost.localdomain> References: <1143848687.18506.39.camel@localhost> <59eb0566983d683b79d83d50ac6dfadd@cl.cam.ac.uk> <1143928012.18506.56.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel , Alex Williamson , xen-ia64-devel List-Id: xen-devel@lists.xenproject.org On Sun, 2006-04-02 at 09:20 +0100, Keir Fraser wrote: > On 1 Apr 2006, at 22:46, Alex Williamson wrote: > > > Here's a patch that enables HYPERVISOR_sched_op() and > > HYPERVISOR_sched_opt_compat() for ia64. We currently have no users of > > this call, but there's no harm in enabling it (tested by adding a > > HYPERVISOR_yield() call to default_idle()). I did notice a problem > > with > > the compat interface though, nothing defines __XEN_INTERFACE_VERSION__ > > for the build of xen. We're therefore stuck on interface version > > 0x00000000 where __HYPERVISOR_sched_op_compat == __HYPERVISOR_sched_op. > > Well, it doesn't actually matter right now since Xen itself does not > use the __HYPERVISOR_foo numbers. But yes, I can see this might bite us > later so we ought to define it. I was using them in some debugging code the other day and it bit me :-( Christian suggested changing xen-compat.h to use the maximum version when compiling Xen. e.g. #ifndef __XEN_INTERFACE_VERSION__ #ifdef __XEN__ #define __XEN_INTERFACE_VERSION__ 0xffffffff #else #define __XEN_INTERFACE_VERSION__ 0x00000000 #endif #endif Ian.