* [PATCH] xenconsoled: close logfile when cleaning up domain
@ 2010-07-19 8:03 Ian Campbell
0 siblings, 0 replies; only message in thread
From: Ian Campbell @ 2010-07-19 8:03 UTC (permalink / raw)
To: xen-devel; +Cc: Ian Campbell
Without this we leak an fd on each domain shutdown and eventually run
out of file descriptors meaning new the console of new domains are not
logged.
Seems to have been accidentally removed in 16638:28921e83000b.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
diff -r 81cc627934c6 -r 11da502b927f tools/console/daemon/io.c
--- a/tools/console/daemon/io.c Mon Jul 19 09:01:24 2010 +0100
+++ b/tools/console/daemon/io.c Mon Jul 19 09:01:24 2010 +0100
@@ -747,6 +747,11 @@
{
domain_close_tty(d);
+ if (d->log_fd != -1) {
+ close(d->log_fd);
+ d->log_fd = -1;
+ }
+
free(d->buffer.data);
d->buffer.data = NULL;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-07-19 8:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-19 8:03 [PATCH] xenconsoled: close logfile when cleaning up domain Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).