From: Julien Grall <julien.grall@linaro.org>
To: George Dunlap <george.dunlap@citrix.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Julien Grall <julien.grall@arm.com>,
Wei Liu <wei.liu2@citrix.com>, Jan Beulich <jbeulich@suse.com>,
Ian Jackson <ian.jackson@citrix.com>
Subject: Re: [PATCH for-4.10] fuzz/x86_emulate: Fix afl-harness batch mode file pointer leak
Date: Tue, 17 Oct 2017 14:39:08 +0100 [thread overview]
Message-ID: <11ed8c04-467b-f80b-6b09-f7951f45095f@linaro.org> (raw)
In-Reply-To: <20171013090016.9042-1-george.dunlap@citrix.com>
Hi George,
On 13/10/17 10:00, George Dunlap wrote:
> Changeset XXXX introduced "batch mode" to afl-harness, which allowed
> the handling of several inputs in sequence.
>
> Unfortunately, it introduced a file pointer leak when the file was
> larger than the maximum size. Restructure the code to always close fp
> if we opened it.
>
> Signed-off-by: George Dunlap <george.dunlap@citrix.com>
> ---
> Release exception justification:
> - This is a bug fix. The problem is relatively minor, but the fix is relatively minor too.
I agree here:
Release-acked-by: Julien Grall <julien.grall@linaro.org>
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-10-17 13:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 9:00 [PATCH for-4.10] fuzz/x86_emulate: Fix afl-harness batch mode file pointer leak George Dunlap
2017-10-13 9:06 ` Jan Beulich
2017-10-13 9:10 ` George Dunlap
2017-10-13 9:20 ` Jan Beulich
2017-10-13 10:23 ` George Dunlap
2017-10-13 10:31 ` Jan Beulich
2017-10-13 10:36 ` George Dunlap
2017-10-13 9:12 ` George Dunlap
2017-10-17 13:39 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11ed8c04-467b-f80b-6b09-f7951f45095f@linaro.org \
--to=julien.grall@linaro.org \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).