From: Julien Grall <julien.grall@arm.com>
To: Amit Tomer <amittomer25@gmail.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
wei.liu2@citrix.com, George Dunlap <George.Dunlap@eu.citrix.com>,
ian.jackson@eu.citrix.com, tim@xen.org,
Andrew Cooper <andrew.cooper3@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Andre Przywara <andre.przywara@arm.com>,
xen-devel@lists.xenproject.org
Subject: Re: [RFC PATCH 1/2] xen/arm: Add Amlogic S905 SoC early printk support
Date: Wed, 22 Aug 2018 10:52:19 +0100 [thread overview]
Message-ID: <122b7b82-af4e-66f7-d210-2b9e0842fbc7@arm.com> (raw)
In-Reply-To: <CABHD4K-K+XNYPZ4e2_kKa-PcAwKd-5OD5V72dTvb9qbr8qQeWA@mail.gmail.com>
On 20/08/18 10:16, Amit Tomer wrote:
> Hello,
Hi Amit,
>> I would prefer if no new alias are added. The same could be achieved with
>> CONFIG_EARLY_PRINTK=meson,0xc81004c0.
>>
>> This could be documented on the wiki.
>
> Ok.
>
>> I would prefer if we stick with the spec name. So UART_TX_REG should be
>> renamed UART_WFIFO_REG.
>
> Yeah right, got your point.
>>
>> Also, it might be worth considering to prefix them with AML_ so it is easy
>> to find them on lookup.
>
> Initially used AML_ as prefix but then I just wanted to be consistent it with
> other uart drivers in XEN.
I think I would prefer to be prefixed with AML_. The non-prefixed
version is not that convenient for lookup and adding an extra one is not
going to make better.
>
>> Looking at the earlyconsole implementation in Linux, it seems that TX needs
>> to be enabled first (see meson_uart_enable_tx_engine).
>>
>> Is it now done in the firmware?
>
> Yes, this has been done in u-boot.
> shouldn't we trust it?
I am trying to understand why Linux is doing it. Do you expect all
U-Boot version to do it?
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-08-22 9:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 17:07 [RFC PATCH 0/2] xen/arm64: Add Support for Amlogic S905 SoC Amit Singh Tomar
2018-08-07 17:07 ` [RFC PATCH 1/2] xen/arm: Add Amlogic S905 SoC early printk support Amit Singh Tomar
2018-08-14 10:01 ` Julien Grall
2018-08-20 9:16 ` Amit Tomer
2018-08-22 9:52 ` Julien Grall [this message]
2018-09-12 6:43 ` Amit Tomer
2018-09-12 9:12 ` Julien Grall
2018-10-22 23:31 ` André Przywara
2018-11-17 8:47 ` Amit Tomer
2018-08-07 17:07 ` [RFC PATCH 2/2] xen/arm: Add MESON UART driver for Amlogic S905 SoC Amit Singh Tomar
2018-08-08 10:05 ` Jan Beulich
2018-08-14 10:17 ` Julien Grall
2018-08-20 8:12 ` Amit Tomer
2018-08-22 10:00 ` Julien Grall
2018-10-04 7:11 ` Amit Tomer
2018-10-09 10:25 ` Julien Grall
2018-10-22 23:31 ` André Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=122b7b82-af4e-66f7-d210-2b9e0842fbc7@arm.com \
--to=julien.grall@arm.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=amittomer25@gmail.com \
--cc=andre.przywara@arm.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).