From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: [PATCH] libxl: Fix up some incorrect printf formats Date: Thu, 27 May 2010 16:55:16 +0100 Message-ID: <1274975721-3777-10-git-send-email-ian.jackson@eu.citrix.com> References: <1274975721-3777-1-git-send-email-ian.jackson@eu.citrix.com> <1274975721-3777-2-git-send-email-ian.jackson@eu.citrix.com> <1274975721-3777-3-git-send-email-ian.jackson@eu.citrix.com> <1274975721-3777-4-git-send-email-ian.jackson@eu.citrix.com> <1274975721-3777-5-git-send-email-ian.jackson@eu.citrix.com> <1274975721-3777-6-git-send-email-ian.jackson@eu.citrix.com> <1274975721-3777-7-git-send-email-ian.jackson@eu.citrix.com> <1274975721-3777-8-git-send-email-ian.jackson@eu.citrix.com> <1274975721-3777-9-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1274975721-3777-9-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: Ian Jackson List-Id: xen-devel@lists.xenproject.org We need to use PRIu32 for domids, and also to pass arguments in the right order. Signed-off-by: Ian Jackson --- tools/libxl/libxl.c | 4 ++-- tools/libxl/libxl_dom.c | 2 +- tools/libxl/libxl_xshelp.c | 3 ++- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index 8fd4481..6adb9e5 100644 --- a/tools/libxl/libxl.c +++ b/tools/libxl/libxl.c @@ -230,7 +230,7 @@ int libxl_domain_rename(struct libxl_ctx *ctx, uint32_t domid, new_name, strlen(new_name))) { XL_LOG(ctx, XL_LOG_ERROR, "failed to write new name `%s'" " for domain %"PRIu32" previously named `%s'", - domid, new_name, old_name); + new_name, domid, old_name); goto x_fail; } @@ -240,7 +240,7 @@ int libxl_domain_rename(struct libxl_ctx *ctx, uint32_t domid, if (errno != EAGAIN) { XL_LOG(ctx, XL_LOG_ERROR, "failed to commit new name `%s'" " for domain %"PRIu32" previously named `%s'", - domid, new_name, old_name); + new_name, domid, old_name); goto x_fail; } XL_LOG(ctx, XL_LOG_DEBUG, "need to retry rename transaction" diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c index 483a928..ba7dfe0 100644 --- a/tools/libxl/libxl_dom.c +++ b/tools/libxl/libxl_dom.c @@ -386,7 +386,7 @@ static const char *userdata_path(struct libxl_ctx *ctx, uint32_t domid, rc = libxl_domain_info(ctx, &info, domid); if (rc) { XL_LOG_ERRNO(ctx, XL_LOG_ERROR, "unable to find domain info" - " for domain %l"PRIu32, domid); + " for domain %"PRIu32, domid); return 0; } uuid_string = string_of_uuid(ctx, info.uuid); diff --git a/tools/libxl/libxl_xshelp.c b/tools/libxl/libxl_xshelp.c index 16e8c84..b5c6dbf 100644 --- a/tools/libxl/libxl_xshelp.c +++ b/tools/libxl/libxl_xshelp.c @@ -19,6 +19,7 @@ #include #include #include +#include #include "libxl.h" #include "libxl_internal.h" @@ -119,7 +120,7 @@ char *libxl_xs_get_dompath(struct libxl_ctx *ctx, uint32_t domid) { char *s = xs_get_domain_path(ctx->xsh, domid); if (!s) { - XL_LOG_ERRNO(ctx, XL_LOG_ERROR, "failed to get dompath for %lu", + XL_LOG_ERRNO(ctx, XL_LOG_ERROR, "failed to get dompath for %" PRIu32, domid); return NULL; } -- 1.5.6.5