From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [PATCH] xl: Move "extern" declarations to xl.h
Date: Thu, 27 May 2010 16:55:09 +0100 [thread overview]
Message-ID: <1274975721-3777-3-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1274975721-3777-2-git-send-email-ian.jackson@eu.citrix.com>
Declarations (as opposed to definitions) of external objects should
not appear in .c files.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
tools/libxl/xl.c | 3 ---
tools/libxl/xl.h | 3 +++
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/libxl/xl.c b/tools/libxl/xl.c
index 82ab873..77eaa7b 100644
--- a/tools/libxl/xl.c
+++ b/tools/libxl/xl.c
@@ -31,9 +31,6 @@
#include "libxl_utils.h"
#include "xl.h"
-extern struct libxl_ctx ctx;
-extern int logfile;
-
void log_callback(
void *userdata, int loglevel, const char *file,
int line, const char *func, char *s)
diff --git a/tools/libxl/xl.h b/tools/libxl/xl.h
index faf784a..450a12f 100644
--- a/tools/libxl/xl.h
+++ b/tools/libxl/xl.h
@@ -74,4 +74,7 @@ void help(char *command);
extern struct cmd_spec cmd_table[];
extern int cmdtable_len;
+extern struct libxl_ctx ctx;
+extern int logfile;
+
#endif /* XL_H */
--
1.5.6.5
next prev parent reply other threads:[~2010-05-27 15:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 15:55 [PATCH 00/14] Logging cleanups, libxc API change Ian Jackson
2010-05-27 15:55 ` [PATCH] xl: Combine headers into one header file Ian Jackson
2010-05-27 15:55 ` Ian Jackson [this message]
2010-05-27 15:55 ` [PATCH] stubdom/newlib: Provide correct names for time.h timezone variables Ian Jackson
2010-05-27 15:55 ` [PATCH] libxc: xc_domain_save.c: rename "write_exact" macro Ian Jackson
2010-05-27 15:55 ` [PATCH] libelf: Tidy up logging and remove dependency on stdio Ian Jackson
2010-05-27 15:55 ` [PATCH] xtl: New xentoollog mini-library Ian Jackson
2010-05-27 15:55 ` [PATCH] libxc: eliminate static variables, use xentoollog; API change Ian Jackson
2010-05-27 15:55 ` [PATCH] libxc: Use new DBGPRINTF for a few debugging output messages Ian Jackson
2010-05-27 15:55 ` [PATCH] libxl: Fix up some incorrect printf formats Ian Jackson
2010-05-27 15:55 ` [PATCH] libxl: Use the caller's logger (xentoollog) Ian Jackson
2010-05-27 15:55 ` [PATCH] xl: Allow control of logging level Ian Jackson
2010-05-27 15:55 ` [PATCH] libxc: save/restore error handling fixes Ian Jackson
2010-05-27 15:55 ` [PATCH] libxc: remove \n from strings passed to PERROR Ian Jackson
2010-05-27 15:55 ` [PATCH] xl/libxtl: Remove glitch in xl migrate log output Ian Jackson
2010-05-27 15:58 ` [PATCH 00/14] Logging cleanups, libxc API change Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274975721-3777-3-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).