From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: [PATCH] xl: Move "extern" declarations to xl.h Date: Thu, 27 May 2010 16:55:09 +0100 Message-ID: <1274975721-3777-3-git-send-email-ian.jackson@eu.citrix.com> References: <1274975721-3777-1-git-send-email-ian.jackson@eu.citrix.com> <1274975721-3777-2-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1274975721-3777-2-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: Ian Jackson , Ian Jackson List-Id: xen-devel@lists.xenproject.org Declarations (as opposed to definitions) of external objects should not appear in .c files. Signed-off-by: Ian Jackson --- tools/libxl/xl.c | 3 --- tools/libxl/xl.h | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/libxl/xl.c b/tools/libxl/xl.c index 82ab873..77eaa7b 100644 --- a/tools/libxl/xl.c +++ b/tools/libxl/xl.c @@ -31,9 +31,6 @@ #include "libxl_utils.h" #include "xl.h" -extern struct libxl_ctx ctx; -extern int logfile; - void log_callback( void *userdata, int loglevel, const char *file, int line, const char *func, char *s) diff --git a/tools/libxl/xl.h b/tools/libxl/xl.h index faf784a..450a12f 100644 --- a/tools/libxl/xl.h +++ b/tools/libxl/xl.h @@ -74,4 +74,7 @@ void help(char *command); extern struct cmd_spec cmd_table[]; extern int cmdtable_len; +extern struct libxl_ctx ctx; +extern int logfile; + #endif /* XL_H */ -- 1.5.6.5