From: Ian Campbell <ian.campbell@citrix.com>
To: jeremy@goop.org
Cc: Steven.Smith@eu.citrix.com, xen-devel@lists.xensource.com,
Ian Campbell <ian.campbell@citrix.com>,
JBeulich@novell.com
Subject: [PATCH 3/4] xen: netback: drop frag member from struct netbk_rx_meta
Date: Fri, 11 Jun 2010 15:19:10 +0100 [thread overview]
Message-ID: <1276265951-24490-3-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1276265928.19091.3469.camel@zakaz.uk.xensource.com>
It has been unused since c3219dc "xen/netback: completely drop flip
support", as has netbk_free_pages().
(Although it now has only a single member struct netbk_rx_meta will
gain other members in a subsequent patch so there is no point
reworking to get rid of the struct)
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
drivers/xen/netback/common.h | 1 -
drivers/xen/netback/netback.c | 8 --------
2 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/drivers/xen/netback/common.h b/drivers/xen/netback/common.h
index 81050a6..84b527d 100644
--- a/drivers/xen/netback/common.h
+++ b/drivers/xen/netback/common.h
@@ -232,7 +232,6 @@ struct pending_tx_info {
typedef unsigned int pending_ring_idx_t;
struct netbk_rx_meta {
- skb_frag_t frag;
int id;
};
diff --git a/drivers/xen/netback/netback.c b/drivers/xen/netback/netback.c
index 8cd7875..6de29d2 100644
--- a/drivers/xen/netback/netback.c
+++ b/drivers/xen/netback/netback.c
@@ -411,14 +411,6 @@ static void netbk_gop_skb(struct sk_buff *skb,
netif->rx.req_cons += nr_frags + extra;
}
-static inline void netbk_free_pages(int nr_frags, struct netbk_rx_meta *meta)
-{
- int i;
-
- for (i = 0; i < nr_frags; i++)
- put_page(meta[i].frag.page);
-}
-
/* This is a twin to netbk_gop_skb. Assume that netbk_gop_skb was
used to set up the operations on the top of
netrx_pending_operations, which have since been done. Check that
--
1.5.6.5
next prev parent reply other threads:[~2010-06-11 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 14:18 [GIT 0/4] netback patches from XCP patch queue Ian Campbell
2010-06-11 14:19 ` [PATCH 1/4] xen: netback: Fixes for delayed copy of tx network packets Ian Campbell
2010-06-11 14:19 ` [PATCH 2/4] xen: netback: handle NET_SKBUFF_DATA_USES_OFFSET correctly Ian Campbell
2010-06-11 14:19 ` Ian Campbell [this message]
2010-06-11 14:19 ` [PATCH 4/4] xen/netback: linearise SKBs as we copy them into guest memory on guest-RX Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276265951-24490-3-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=JBeulich@novell.com \
--cc=Steven.Smith@eu.citrix.com \
--cc=jeremy@goop.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).