From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: [PATCH] xen: netback: do not unleash netback threads until initialisation is complete Date: Fri, 30 Jul 2010 15:16:46 +0100 Message-ID: <1280499407-7496-1-git-send-email-ian.campbell@citrix.com> References: <1280499392.24292.1964.camel@zakaz.uk.xensource.com> Return-path: In-Reply-To: <1280499392.24292.1964.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com Cc: Jeremy Fitzhardinge , xen-devel@lists.xensource.com, Paul Durrant , Ian Campbell , "Xu, Dongxiao" List-Id: xen-devel@lists.xenproject.org Otherwise netbk_action_thread can reference &netbk->net_schedule_list (via tx_work_todo) before it is initialised. Until now it was zeroed which is probably safe but not exactly robust. Signed-off-by: Ian Campbell Cc: Jeremy Fitzhardinge Cc: Xu, Dongxiao Cc: Paul Durrant --- drivers/xen/netback/netback.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/xen/netback/netback.c b/drivers/xen/netback/netback.c index 4121062..0ed7e61 100644 --- a/drivers/xen/netback/netback.c +++ b/drivers/xen/netback/netback.c @@ -1781,7 +1781,6 @@ static int __init netback_init(void) if (!IS_ERR(netbk->kthread.task)) { kthread_bind(netbk->kthread.task, group); - wake_up_process(netbk->kthread.task); } else { printk(KERN_ALERT "kthread_run() fails at netback\n"); @@ -1807,6 +1806,9 @@ static int __init netback_init(void) spin_lock_init(&netbk->net_schedule_list_lock); atomic_set(&netbk->netfront_count, 0); + + if (MODPARM_netback_kthread) + wake_up_process(netbk->kthread.task); } netbk_copy_skb_mode = NETBK_DONT_COPY_SKB; -- 1.5.6.5