From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com
Cc: alex.williamson@redhat.com, Jeremy Fitzhardinge <jeremy@goop.org>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: [PATCH 02/20] xen: define BIOVEC_PHYS_MERGEABLE()
Date: Wed, 4 Aug 2010 14:18:57 -0400 [thread overview]
Message-ID: <1280945955-14229-3-git-send-email-konrad.wilk@oracle.com> (raw)
In-Reply-To: <1280945955-14229-1-git-send-email-konrad.wilk@oracle.com>
From: Jeremy Fitzhardinge <jeremy@goop.org>
Impact: allow Xen control of bio merging
When running in Xen domain with device access, we need to make sure
the block subsystem doesn't merge requests across pages which aren't
machine physically contiguous. To do this, we define our own
BIOVEC_PHYS_MERGEABLE. When CONFIG_XEN isn't enabled, or we're not
running in a Xen domain, this has identical behaviour to the normal
implementation. When running under Xen, we also make sure the
underlying machine pages are the same or adjacent.
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
arch/x86/include/asm/io.h | 13 +++++++++++++
drivers/xen/Makefile | 2 +-
drivers/xen/biomerge.c | 13 +++++++++++++
3 files changed, 27 insertions(+), 1 deletions(-)
create mode 100644 drivers/xen/biomerge.c
diff --git a/arch/x86/include/asm/io.h b/arch/x86/include/asm/io.h
index 30a3e97..0ad29d4 100644
--- a/arch/x86/include/asm/io.h
+++ b/arch/x86/include/asm/io.h
@@ -41,6 +41,8 @@
#include <asm-generic/int-ll64.h>
#include <asm/page.h>
+#include <xen/xen.h>
+
#define build_mmio_read(name, size, type, reg, barrier) \
static inline type name(const volatile void __iomem *addr) \
{ type ret; asm volatile("mov" size " %1,%0":reg (ret) \
@@ -349,6 +351,17 @@ extern void __iomem *early_memremap(resource_size_t phys_addr,
extern void early_iounmap(void __iomem *addr, unsigned long size);
extern void fixup_early_ioremap(void);
+#ifdef CONFIG_XEN
+struct bio_vec;
+
+extern bool xen_biovec_phys_mergeable(const struct bio_vec *vec1,
+ const struct bio_vec *vec2);
+
+#define BIOVEC_PHYS_MERGEABLE(vec1, vec2) \
+ (__BIOVEC_PHYS_MERGEABLE(vec1, vec2) && \
+ (!xen_domain() || xen_biovec_phys_mergeable(vec1, vec2)))
+#endif /* CONFIG_XEN */
+
#define IO_SPACE_LIMIT 0xffff
#endif /* _ASM_X86_IO_H */
diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
index 7c28434..97dd5b5 100644
--- a/drivers/xen/Makefile
+++ b/drivers/xen/Makefile
@@ -1,4 +1,4 @@
-obj-y += grant-table.o features.o events.o manage.o
+obj-y += grant-table.o features.o events.o manage.o biomerge.o
obj-y += xenbus/
nostackp := $(call cc-option, -fno-stack-protector)
diff --git a/drivers/xen/biomerge.c b/drivers/xen/biomerge.c
new file mode 100644
index 0000000..ba6eda4
--- /dev/null
+++ b/drivers/xen/biomerge.c
@@ -0,0 +1,13 @@
+#include <linux/bio.h>
+#include <linux/io.h>
+#include <xen/page.h>
+
+bool xen_biovec_phys_mergeable(const struct bio_vec *vec1,
+ const struct bio_vec *vec2)
+{
+ unsigned long mfn1 = pfn_to_mfn(page_to_pfn(vec1->bv_page));
+ unsigned long mfn2 = pfn_to_mfn(page_to_pfn(vec2->bv_page));
+
+ return __BIOVEC_PHYS_MERGEABLE(vec1, vec2) &&
+ ((mfn1 == mfn2) || ((mfn1+1) == mfn2));
+}
--
1.7.0.1
next prev parent reply other threads:[~2010-08-04 18:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 18:18 [RFC PATCH] Xen PCI frontend driver (v0.5) Konrad Rzeszutek Wilk
2010-08-04 18:18 ` [PATCH 01/20] xen: Don't disable the I/O space Konrad Rzeszutek Wilk
2010-08-04 18:18 ` Konrad Rzeszutek Wilk [this message]
2010-08-04 18:18 ` [PATCH 03/20] xen: implement pirq type event channels Konrad Rzeszutek Wilk
2010-08-04 18:18 ` [PATCH 04/20] x86/io_apic: add get_nr_irqs_gsi() Konrad Rzeszutek Wilk
2010-08-04 18:19 ` [PATCH 05/20] xen: identity map gsi->irqs Konrad Rzeszutek Wilk
2010-08-04 18:19 ` [PATCH 06/20] xen: dynamically allocate irq & event structures Konrad Rzeszutek Wilk
2010-08-04 18:19 ` [PATCH 07/20] xen: set pirq name to something useful Konrad Rzeszutek Wilk
2010-08-04 18:19 ` [PATCH 08/20] xen: statically initialize cpu_evtchn_mask_p Konrad Rzeszutek Wilk
2010-08-04 18:19 ` [PATCH 09/20] xen: Find an unbound irq number in reverse order (high to low) Konrad Rzeszutek Wilk
2010-08-04 18:19 ` [PATCH 10/20] xen: Provide a variant of xen_poll_irq with timeout Konrad Rzeszutek Wilk
2010-08-04 18:19 ` [PATCH 11/20] xen: fix shared irq device passthrough Konrad Rzeszutek Wilk
2010-08-04 18:19 ` [PATCH 12/20] x86/PCI: Clean up pci_cache_line_size Konrad Rzeszutek Wilk
2010-08-04 18:19 ` [PATCH 13/20] x86/PCI: make sure _PAGE_IOMAP it set on pci mappings Konrad Rzeszutek Wilk
2010-08-04 18:19 ` [PATCH 14/20] x86/PCI: Export pci_walk_bus function Konrad Rzeszutek Wilk
2010-08-04 18:19 ` [PATCH 15/20] x86: Copy-n-paste arch_teardown_msi_irqs from msi.c to io_apic.c Konrad Rzeszutek Wilk
2010-08-04 18:19 ` [PATCH 16/20] x86: Introduce x86_msi_ops Konrad Rzeszutek Wilk
2010-08-31 18:31 ` Konrad Rzeszutek Wilk
2010-09-23 14:48 ` Konrad Rzeszutek Wilk
2010-09-23 23:18 ` [Xen-devel] " Bruce Edge
2010-10-07 2:59 ` Konrad Rzeszutek Wilk
2010-08-04 18:19 ` [PATCH 17/20] xen/x86/PCI: Add support for the Xen PCI subsystem Konrad Rzeszutek Wilk
2010-08-13 23:28 ` Jesse Barnes
2010-10-04 18:30 ` Konrad Rzeszutek Wilk
2010-08-04 18:19 ` [PATCH 18/20] xenbus: Xen paravirtualised PCI hotplug support Konrad Rzeszutek Wilk
2010-08-04 18:19 ` [PATCH 19/20] xenbus: prevent warnings on unhandled enumeration values Konrad Rzeszutek Wilk
2010-08-04 18:19 ` [PATCH 20/20] xen-pcifront: Xen PCI frontend driver Konrad Rzeszutek Wilk
2010-08-04 20:14 ` [Xen-devel] [RFC PATCH] Xen PCI frontend driver (v0.5) Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280945955-14229-3-git-send-email-konrad.wilk@oracle.com \
--to=konrad.wilk@oracle.com \
--cc=alex.williamson@redhat.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).