From: Gianni Tedesco <gianni.tedesco@citrix.com>
To: Christoph Egger <Christoph.Egger@amd.com>
Cc: Ian,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: tools: build error
Date: Wed, 22 Sep 2010 18:27:22 +0100 [thread overview]
Message-ID: <1285176442.6309.11.camel@qabil.uk.xensource.com> (raw)
In-Reply-To: <201009221459.00659.Christoph.Egger@amd.com>
On Wed, 2010-09-22 at 13:59 +0100, Christoph Egger wrote:
> Hi!
>
> Changeset 22167:330c4d9010da breaks the build.
>
> It adds blktapctl to link against in setup.py which isn't build
> on NetBSD.
Oops, Following ought to fix it:
----8<------------------------------------------------------
Link to libblktapctl in python setup only for platforms which build it
Signed-off-by: Gianni Tedesco <gianni.tedesco@citrix.com>
diff -r 36420e35c65a tools/python/setup.py
--- a/tools/python/setup.py Wed Sep 22 16:57:12 2010 +0100
+++ b/tools/python/setup.py Wed Sep 22 18:25:22 2010 +0100
@@ -14,8 +14,7 @@ include_dirs = [ XEN_ROOT + "/tools/libx
library_dirs = [ XEN_ROOT + "/tools/libxc",
XEN_ROOT + "/tools/xenstore",
- XEN_ROOT + "/tools/libxl",
- XEN_ROOT + "/tools/blktap2/control",
+ XEN_ROOT + "/tools/libxl"
]
libraries = [ "xenctrl", "xenguest", "xenstore" ]
@@ -23,8 +22,11 @@ libraries = [ "xenctrl", "xenguest", "xe
plat = os.uname()[0]
if plat == 'Linux':
uuid_libs = ["uuid"]
+ blktap_ctl_libs = ["blktapctl"]
+ library_dirs.append(XEN_ROOT + "/tools/blktap2/control")
else:
uuid_libs = []
+ blktap_ctl_libs = []
xc = Extension("xc",
extra_compile_args = extra_compile_args,
@@ -96,7 +98,7 @@ xl = Extension("xl",
extra_compile_args = extra_compile_args,
include_dirs = include_dirs + [ "xen/lowlevel/xl" ],
library_dirs = library_dirs,
- libraries = libraries + ["xenlight", "blktapctl" ] + uuid_libs,
+ libraries = libraries + ["xenlight" ] + blktap_ctl_libs + uuid_libs,
sources = [ "xen/lowlevel/xl/xl.c", "xen/lowlevel/xl/_pyxl_types.c" ])
modules = [ xc, xs, ptsname, acm, flask, xl ]
next prev parent reply other threads:[~2010-09-22 17:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 12:59 tools: build error Christoph Egger
2010-09-22 17:27 ` Gianni Tedesco [this message]
2010-09-23 11:51 ` Christoph Egger
2010-09-23 15:30 ` Gianni Tedesco
-- strict thread matches above, loose matches on Subject: below --
2010-02-22 18:15 Christoph Egger
2010-02-22 18:43 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285176442.6309.11.camel@qabil.uk.xensource.com \
--to=gianni.tedesco@citrix.com \
--cc=Christoph.Egger@amd.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).