From: Gianni Tedesco <gianni.tedesco@citrix.com>
To: Juergen Gross <juergen.gross@ts.fujitsu.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 1 of 5] Support getting topology info in libxl
Date: Thu, 9 Dec 2010 13:11:48 +0000 [thread overview]
Message-ID: <1291900308.20366.1.camel@qabil.uk.xensource.com> (raw)
In-Reply-To: <a1eb18bec4690b6687bc.1291898377@nehalem1>
On Thu, 2010-12-09 at 12:39 +0000, Juergen Gross wrote:
>
> +PyObject *attrib__libxl_cpuarray_get(libxl_cpuarray *pptr)
> +{
> + PyObject *list = NULL;
> + int i;
> +
> + list = PyList_New(0);
> + for (i = 0; i < pptr->entries; i++) {
> + if (pptr->array[i] == LIBXL_CPUARRAY_INVALID_ENTRY) {
> + PyList_Append(list, Py_None);
> + Py_INCREF(Py_None);
Actually I think I am the one who is confused. It is the other way
around. I need to fix other places that leak references due to this.
IOW, this was good to go first time around, tried to respond earlier but
my mail client barfed the message.
Sorry for the noise! :(
Gianni
next prev parent reply other threads:[~2010-12-09 13:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-23 2:08 [PATCH] fix build error in libxl Zhang, Yang Z
2011-01-03 13:40 ` Christoph Egger
2010-12-09 12:39 ` [PATCH 0 of 5] support of NUMA topology in xl Juergen Gross
2010-12-09 12:39 ` [PATCH 1 of 5] Support getting topology info in libxl Juergen Gross
2010-12-09 13:11 ` Gianni Tedesco [this message]
2010-12-09 13:19 ` Juergen Gross
2010-12-10 17:30 ` Ian Jackson
2010-12-09 12:39 ` [PATCH 2 of 5] support topolgy info in xl info Juergen Gross
2010-12-09 12:39 ` [PATCH 3 of 5] Extend cpupools to support numa Juergen Gross
2010-12-09 12:39 ` [PATCH 4 of 5] Support renaming of cpupools Juergen Gross
2010-12-09 12:39 ` [PATCH 5 of 5] Support new xl command cpupool-numa-split Juergen Gross
2010-12-17 6:09 ` [PATCH 0 of 5] support of NUMA topology in xl Juergen Gross
2010-12-17 17:46 ` Ian Jackson
2010-12-17 17:50 ` Keir Fraser
2010-12-17 21:42 ` [PATCH] xl: fix compilation warning on libxl.c Wei Huang
2011-01-05 23:39 ` [PATCH] xl: fix compilation warning on libxl.c [and 2 more messages] Ian Jackson
-- strict thread matches above, loose matches on Subject: below --
2010-12-09 10:51 [PATCH 0 of 5] support of NUMA topology in xl Juergen Gross
2010-12-09 10:51 ` [PATCH 1 of 5] Support getting topology info in libxl Juergen Gross
2010-12-23 16:02 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291900308.20366.1.camel@qabil.uk.xensource.com \
--to=gianni.tedesco@citrix.com \
--cc=juergen.gross@ts.fujitsu.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).