xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: anthony.perard@citrix.com
To: Xen Devel <xen-devel@lists.xensource.com>
Cc: anthony.perard@citrix.com
Subject: [PATCH 2/5] libxl: strdup disk path before put it in qemu args array.
Date: Fri, 10 Dec 2010 12:31:15 +0000	[thread overview]
Message-ID: <1291984275-5331-1-git-send-email-anthony.perard@citrix.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1012101216240.25952@perard.cam.xci-test.com>

From: Anthony PERARD <anthony.perard@citrix.com>

In libxl_build_device_model_args_new, the path to the disk image are
freeed before there was actually use to make the arguments list of Qemu.
The patch strdups it.

Also it changes argv[0] of the device model from "qemu-system-xen" to
"qemu-dm".

---
 tools/libxl/libxl.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
index 0feb93f..0f6e632 100644
--- a/tools/libxl/libxl.c
+++ b/tools/libxl/libxl.c
@@ -1256,9 +1256,9 @@ static char ** libxl_build_device_model_args_new(libxl__gc *gc,
     if (!dm_args)
         return NULL;
 
-    flexarray_set(dm_args, num++, "qemu-system-xen");
-    flexarray_set(dm_args, num++, "-xen-domid");
+    flexarray_set(dm_args, num++, "qemu-dm");
 
+    flexarray_set(dm_args, num++, "-xen-domid");
     flexarray_set(dm_args, num++, libxl__sprintf(gc, "%d", info->domid));
 
     if (info->dom_name) {
@@ -1378,10 +1378,10 @@ static char ** libxl_build_device_model_args_new(libxl__gc *gc,
     for (i; i < nb; i++) {
         if ( disks[i].is_cdrom ) {
             flexarray_set(dm_args, num++, "-cdrom");
-            flexarray_set(dm_args, num++, disks[i].physpath);
-        }else{
+            flexarray_set(dm_args, num++, libxl__strdup(gc, disks[i].physpath));
+        } else {
             flexarray_set(dm_args, num++, libxl__sprintf(gc, "-%s", disks[i].virtpath));
-            flexarray_set(dm_args, num++, disks[i].physpath);
+            flexarray_set(dm_args, num++, libxl__strdup(gc, disks[i].physpath));
         }
         libxl_device_disk_destroy(&disks[i]);
     }
-- 
1.7.1

  reply	other threads:[~2010-12-10 12:31 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-09 19:42 [PATCH 0/5] libxl: Some fixes related to Qemu upstream command lines anthony.perard
2010-12-09 19:42 ` [PATCH 1/5] libxl: fix double free of ifname, when makes args for qemu anthony.perard
2010-12-09 19:42 ` [PATCH 2/5] libxl: strdup disk path before put it in qemu args array anthony.perard
2010-12-10  9:09   ` Ian Campbell
2010-12-10 12:29     ` Anthony PERARD
2010-12-10 12:31       ` anthony.perard [this message]
2010-12-10 14:49       ` Ian Campbell
2010-12-10 15:38         ` Anthony PERARD
2010-12-10 16:59           ` [PATCH v1.3 " anthony.perard
2010-12-09 19:42 ` [PATCH 3/5] libxl: Specify the target ram size to Qemu (new) when calling it anthony.perard
2010-12-09 19:42 ` [PATCH 4/5] libxl: Makes libxl be able to call Qemu upstream for XenPV guest anthony.perard
2010-12-10 17:42   ` Ian Jackson
2010-12-10 18:12     ` Anthony PERARD
2010-12-10 18:14       ` Anthony PERARD
2010-12-13 18:19       ` Ian Jackson
2010-12-13 18:43         ` Anthony PERARD
2010-12-14 17:08           ` Ian Jackson
2010-12-09 19:42 ` [PATCH 5/5] libxl: Lists qdisk device in libxl_device_disk_list anthony.perard
2010-12-14 19:26   ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291984275-5331-1-git-send-email-anthony.perard@citrix.com \
    --to=anthony.perard@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).