From: Paul Durrant <paul.durrant@citrix.com>
To: xen-devel@lists.xensource.com
Cc: Paul Durrant <paul.durrant@citrix.com>
Subject: [PATCH] Don't count packets we don't actually receive.
Date: Tue, 14 Dec 2010 20:35:19 +0000 [thread overview]
Message-ID: <1292358922-5569-2-git-send-email-paul.durrant@citrix.com> (raw)
In-Reply-To: <1292358922-5569-1-git-send-email-paul.durrant@citrix.com>
Make sure we only bump rx_packets when we're definitely going to call netif_rx_ni().
Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
---
drivers/xen/netback/netback.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/xen/netback/netback.c b/drivers/xen/netback/netback.c
index 1a4a20e..066d140 100644
--- a/drivers/xen/netback/netback.c
+++ b/drivers/xen/netback/netback.c
@@ -1519,9 +1519,6 @@ static void net_tx_submit(struct xen_netbk *netbk)
skb->dev = netif->dev;
skb->protocol = eth_type_trans(skb, skb->dev);
- netif->stats.rx_bytes += skb->len;
- netif->stats.rx_packets++;
-
if (skb->ip_summed == CHECKSUM_PARTIAL) {
if (skb_checksum_setup(skb)) {
DPRINTK("Can't setup checksum in net_tx_action\n");
@@ -1537,6 +1534,9 @@ static void net_tx_submit(struct xen_netbk *netbk)
continue;
}
+ netif->stats.rx_bytes += skb->len;
+ netif->stats.rx_packets++;
+
netif_rx_ni(skb);
netif->dev->last_rx = jiffies;
}
--
1.5.6.5
next prev parent reply other threads:[~2010-12-14 20:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 20:35 [PATCH] Re-define PKT_PROT_LEN to be bigger Paul Durrant
2010-12-14 20:35 ` Paul Durrant [this message]
2010-12-14 20:35 ` [PATCH] Remove the 500ms timeout to restart the netif queue Paul Durrant
2010-12-14 20:35 ` [PATCH] Add a missing test to tx_work_todo Paul Durrant
2010-12-14 20:35 ` [PATCH] Re-factor net_tx_action_dealloc() slightly Paul Durrant
2010-12-15 15:58 ` [PATCH] Remove the 500ms timeout to restart the netif queue Konrad Rzeszutek Wilk
2010-12-16 10:00 ` Paul Durrant
2010-12-14 22:17 ` [PATCH] Re-define PKT_PROT_LEN to be bigger Jeremy Fitzhardinge
2010-12-15 9:30 ` Paul Durrant
2010-12-15 9:37 ` Ian Campbell
2010-12-20 14:34 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292358922-5569-2-git-send-email-paul.durrant@citrix.com \
--to=paul.durrant@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).