Re: Xen 4.1.0 RC2 released,

[Ian Campbell <Ian.Campbell@eu.citrix.com>]

On Fri, 2011-01-28 at 19:22 +0000, Nathan March wrote: 
> On 1/28/2011 11:12 AM, Ian Campbell wrote:
> > Can you try moving the $(DLOPEN_LIBS) in the libxenctrl rule in
> > tools/libxc/Makefile to the end, e.g. before or after the
> > $(PTHREAD_LIBS)?
> >
> > Ian.
> 
> Moving it to the end fixed it:
> 
> -       $(CC) $(CFLAGS) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) 
> -Wl,libxenctrl.so.$(MAJOR) $(DLOPEN_LIBS) $(SHLIB_LDFLAGS) -o $@ $^ 
> $(PTHREAD_LIBS)
> +       $(CC) $(CFLAGS) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) 
> -Wl,libxenctrl.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $^ $(PTHREAD_LIBS) 
> $(DLOPEN_LIBS)

Excellent. 

> But I'm still running into issues,

Sure. Please can you accumulate all the necessary fixes for the
as-needed stuff and send them out as one patch once it's all fixed up.

> The line that built libvhd.so was:
> 
> gcc  -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g 
> -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes 
> -Wno-unused-value -Wdeclaration-after-statement  -D__XEN_TOOLS__ -MMD 
> -MF .libvhd.o.d  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE  -Werror 
> -Wno-unused -I../../include -D_GNU_SOURCE -fPIC -g -Wp,-MD,.libvhd.o.d 
> -c -o libvhd.o libvhd.c

That's the command for libvhd.o not libvhd.so.

However I would guess that you need to move the $(LIBS) to the end of
the libvhd.a rule in tools/blktap2/vhd/lib/Makefile (which also builds
libvhd.so, go figure).

Ian.