From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@eu.citrix.com>
Subject: Re: Xen 4.1.0 RC2 released,
Date: Mon, 31 Jan 2011 19:30:10 +0000
Message-ID: <1296502210.20804.203.camel@localhost.localdomain>
References: <4D41FA20.40509@gt.net>
	<1296204837.14780.6925.camel@zakaz.uk.xensource.com>
	<4D43146C.50203@gt.net>
	<1296241979.20804.88.camel@localhost.localdomain>
	<4D431792.2040303@gt.net>
	<1296243386.20804.97.camel@localhost.localdomain>
	<4D4332D2.1010506@gt.net>
	<1296251666.20804.99.camel@localhost.localdomain>
	<4D43422A.80202@gt.net>
	<1296297936.20804.123.camel@localhost.localdomain>
	<4D46FC0E.6060102@gt.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4D46FC0E.6060102@gt.net>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Nathan March <nathan@gt.net>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2011-01-31 at 18:14 +0000, Nathan March wrote: 
> 
> On 1/29/2011 2:45 AM, Ian Campbell wrote:
> > I just built Xen with the following patch and it didn't break on a
> > Debian system (i.e. without as-needed enabled by default). Can you try
> > it in your environment?
> 
> Initially failed with:
> 
> ld -Wl,--no-as-needed   -melf_x86_64 -r -o built_in.o head.o
> ld: unrecognized option '-Wl,--no-as-needed'
> ld: use the --help option for usage information

The -Wl,<foo> syntax is for gcc and says "pass <foo> to the linker". If
you are just calling the linker directly then you just need the <foo>
bit (i.e. --as-needed)

However I didn't notice any direct calls to ld when I tested this patch.

Oh, I think I see, the LDFLAGS where patched it effects both the
hypervisor and the tools builds but I only tested the tools.

Can you try the one below instead.

Ian.

diff -r c83acd6f343e tools/Rules.mk
--- a/tools/Rules.mk	Mon Jan 31 09:32:25 2011 +0000
+++ b/tools/Rules.mk	Mon Jan 31 19:29:10 2011 +0000
@@ -52,7 +52,7 @@ ifneq ($(XEN_OS),NetBSD)
 # Enable implicit LFS support *and* explicit LFS names.
 CFLAGS  += $(shell getconf LFS_CFLAGS)
 CFLAGS  += -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
-LDFLAGS += $(shell getconf LFS_LDFLAGS)
+LDFLAGS += $(shell getconf LFS_LDFLAGS) -Wl,--no-as-needed
 endif
 
 # 32-bit x86 does not perform well with -ve segment accesses on Xen.