From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: [PATCH 4/6] libxl: vncviewer: fix use-after-free Date: Tue, 1 Feb 2011 18:25:00 +0000 Message-ID: <1296584702-20138-5-git-send-email-ian.jackson@eu.citrix.com> References: <1296584702-20138-1-git-send-email-ian.jackson@eu.citrix.com> <1296584702-20138-2-git-send-email-ian.jackson@eu.citrix.com> <1296584702-20138-3-git-send-email-ian.jackson@eu.citrix.com> <1296584702-20138-4-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1296584702-20138-4-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: Ian Jackson , Ian Jackson List-Id: xen-devel@lists.xenproject.org This bug can prevent xl vncviewer from working at all. Signed-off-by: Ian Jackson --- tools/libxl/libxl.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index 2d2b884..374e05e 100644 --- a/tools/libxl/libxl.c +++ b/tools/libxl/libxl.c @@ -848,9 +848,8 @@ int libxl_vncviewer_exec(libxl_ctx *ctx, uint32_t domid, int autopass) } skip_autopass: - libxl__free_all(&gc); libxl__exec(autopass_fd, -1, -1, args[0], args); - return 0; + abort(); } /******************************************************************************/ -- 1.5.6.5