From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] pvops: Avoid re-alloc_intr_gate of hvm evtchn callback Date: Sat, 5 Mar 2011 11:59:20 +0000 Message-ID: <1299326360.3731.3.camel@localhost.localdomain> References: <1299322472.13328.67.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Frank Pan Cc: "xen-devel@lists.xensource.com" , Jeremy Fitzhardinge , Konrad Rzeszutek Wilk , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Sat, 2011-03-05 at 11:45 +0000, Frank Pan wrote: > > Thanks. I presume this is against xen/next-2.6.32? Please always mention > > which branch a patch is for. > > FP: Yes, I'll mention it if I have more bugfixes. Thanks. > > The upstream kernel already has this check, and it came from the > > original commit 38e20b07efd5 "x86/xen: event channels delivery on HVM" > > so it looks like the version in the 2.6.32 branch (b24870f7dd7a) was an > > older revision of that patch which lacked this check. > > > > Perhaps you might find it useful to do a sweep through > > git://xenbits.xen.org/people/ianc/linux-2.6.git debian/squeeze/pvhvm-2.6.32.24 > > comparing it to the xen/next-2.6.32 branch? > > FP: I just want a usable version of pvops for doing some research on > migration. Can you suggest a branch which is not too old and a sort of > stable? For PV domU any modern mainline (e.g. kernel.org) kernel should be fine. PVHVM domU support first landed upstream in 2.6.37 so that is the minimum version for that, but again it should be fine for domU use. I'd recommend tracking the upstream 2.6.x.y stable trees -- e.g 2.6.37.2 right now. > > Also your patches need to include a Signed-off-by line in accordance > > with Documentation/SubmittingPatches. > > FP: Gmail sucks on line wrapping, so I also attach the patch inside. > Is that ok? If so, where should I put the "Signed-off-by" line? both? Might as well put it in both. Ian.