From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: changeset 22526:7a5ee3800417 Date: Mon, 07 Mar 2011 16:20:40 +0000 Message-ID: <1299514840.19262.4698.camel@elijah> References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: =?UTF-8?Q?=E5=BC=A0=E9=B9=8F=E9=A3=9E?= Cc: George Dunlap , xen devel List-Id: xen-devel@lists.xenproject.org Hmm, yeah, that's obviously not right! Let me take a look... -George On Mon, 2011-03-07 at 09:55 +0000, =E5=BC=A0=E9=B9=8F=E9=A3=9E wrote: > Hi, > Recently, I did a research on the p2m and EPT,and did apply your > patch(22526) to the source code of mine. But there is one place > confused me: >=20 >=20 > =20 > ept_entry =3D table + index; > 1.91 =20 > 1.92 - ept_entry->emt =3D epte_get_entry_emt(d, gfn, mfn, &i= pat, direct_mmio); > 1.93 - ept_entry->ipat =3D ipat; > 1.94 - ept_entry->sp =3D i ? 1 : 0; > 1.95 - ept_entry->avail1 =3D p2mt; > 1.96 - ept_entry->avail2 =3D 0; > 1.97 + new_entry.emt =3D epte_get_entry_emt(d, gfn, mfn, &ip= at, direct_mmio); > 1.98 + new_entry.ipat =3D ipat; > 1.99 + new_entry.sp =3D i ? 1 : 0; > 1.100 + new_entry.avail1 =3D p2mt; > 1.101 + new_entry.avail2 =3D 0; > 1.102 =20 > 1.103 - if ( ept_entry->mfn =3D=3D mfn_x(mfn) ) > 1.104 + if ( new_entry.mfn =3D=3D mfn_x(mfn) ) > 1.105 need_modify_vtd_table =3D 0; > 1.106 else /* the caller should take care of the previous p= age */ > 1.107 - ept_entry->mfn =3D mfn_x(mfn); > 1.108 + new_entry.mfn =3D mfn_x(mfn); >=20 > I think, The new_entry.mfn is used without assigned any value. Maybe th= ere was something else I did not think of. > Thank you for your kindness! >=20 > http://xenbits.xen.org/xen-unstable.hg/rev/7a5ee3800417