From: Ian Campbell <Ian.Campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 25 of 30] libxl: move libxl_doimid_valid_guest out of line
Date: Thu, 24 Mar 2011 14:28:59 +0000 [thread overview]
Message-ID: <1300976939.11560.157.camel@cthulhu.hellion.org.uk> (raw)
In-Reply-To: <19850.9837.692296.511537@mariner.uk.xensource.com>
On Wed, 2011-03-23 at 16:57 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH 25 of 30] libxl: move libxl_doimid_valid_guest out of line"):
> > Why should it be inline?
>
> In general, I think it's fine to have trivial operations like this
> inlined. Things which one would otherwise maybe use a macro for.
>
> > What actually led to the changes was that a subsequent patch removed the
> > indirect dependency which defined DOMID_FIRST_RESERVED. Rather than
> > finding and adding the appropriate xen header to libxl.h (which is a
> > valid option) I decided that the function shouldn't have been inline in
> > the first place...
>
> I think it's fine to import Xen headers into libxl.h.
In any case whatever it was which caused me to do this is not present in
the final series I ended up sending and neither this patch nor any
additional #includes are required AFAICT.
Ian.
next prev parent reply other threads:[~2011-03-24 14:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <patchbomb.1300723178@localhost.localdomain>
[not found] ` <28f04a6595064dca0062.1300723181@localhost.localdomain>
2011-03-21 17:42 ` [PATCH 03 of 30] tools: vnet: Remove Ian Jackson
2011-03-21 19:19 ` Ian Campbell
2011-03-31 17:08 ` Ian Jackson
2011-04-01 10:21 ` Ian Campbell
2011-04-01 10:30 ` Keir Fraser
[not found] ` <2276552067f8cad61231.1300723198@localhost.localdomain>
2011-03-23 15:40 ` [PATCH 20 of 30] tools: ocaml: push CFLAGS usage down into the specific bindings Ian Jackson
2011-03-23 15:50 ` Ian Campbell
[not found] ` <83ba7f8b634d542fea89.1300723202@localhost.localdomain>
2011-03-23 15:51 ` [PATCH 24 of 30] tools: Remove $(CFLAGS) from links lines Ian Jackson
[not found] ` <825082d71dd594e0eee4.1300723203@localhost.localdomain>
2011-03-23 15:52 ` [PATCH 25 of 30] libxl: move libxl_doimid_valid_guest out of line Ian Jackson
2011-03-23 15:59 ` Ian Campbell
2011-03-23 16:57 ` Ian Jackson
2011-03-24 14:28 ` Ian Campbell [this message]
[not found] ` <dd0e1d4aae8f95979df3.1300723206@localhost.localdomain>
2011-03-23 15:56 ` [PATCH 28 of 30] libxl: do not expose libxenctrl/libxenstore headers via libxl.h Ian Jackson
[not found] ` <26ba6a80310af7c3b360.1300723208@localhost.localdomain>
2011-03-23 16:01 ` [PATCH 30 of 30] tools: remove pattern matched linking rules Ian Jackson
2011-03-23 16:04 ` Ian Campbell
2011-03-21 14:44 [PATCH 00 of 30] tools: shave build yaks Ian Campbell
2011-03-21 14:44 ` [PATCH 25 of 30] libxl: move libxl_doimid_valid_guest out of line Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300976939.11560.157.camel@cthulhu.hellion.org.uk \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).