From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH 1 of 3] xentrace: correct formula to
 calculate t_info_pages
Date: Fri, 01 Apr 2011 11:32:19 +0100
Message-ID: <1301653939.9447.11.camel@elijah>
References: <patchbomb.1301508272@localhost>
	<8a2ce5e49b2c5f2e0137.1301508273@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <8a2ce5e49b2c5f2e0137.1301508273@localhost>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Olaf Hering <olaf@aepfle.de>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Acked-by: George Dunlap <george.dunlap@eu.citrix.com>

On Wed, 2011-03-30 at 19:04 +0100, Olaf Hering wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@aepfle.de>
> # Date 1301423840 -7200
> # Node ID 8a2ce5e49b2c5f2e013734b5d53eae37572f4101
> # Parent  45eeeb6d0481efaab2a59941e1b8e061aead37d4
> xentrace: correct formula to calculate t_info_pages
> 
> The current formula to calculate t_info_pages, based on the initial
> code, is slightly incorrect. It may allocate more than needed.
> Each cpu has some pages/mfns stored as uint32_t.
> That list is stored with an offset at tinfo.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> 
> ---
>  xen/common/trace.c |    7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff -r 45eeeb6d0481 -r 8a2ce5e49b2c xen/common/trace.c
> --- a/xen/common/trace.c	Tue Mar 29 16:34:01 2011 +0100
> +++ b/xen/common/trace.c	Tue Mar 29 20:37:20 2011 +0200
> @@ -110,7 +110,7 @@
>  {
>      struct t_buf dummy;
>      typeof(dummy.prod) size;
> -    unsigned int t_info_words, t_info_bytes;
> +    unsigned int t_info_words;
>  
>      /* force maximum value for an unsigned type */
>      size = -1;
> @@ -125,9 +125,8 @@
>          pages = size;
>      }
>  
> -    t_info_words = num_online_cpus() * pages + t_info_first_offset;
> -    t_info_bytes = t_info_words * sizeof(uint32_t);
> -    t_info_pages = PFN_UP(t_info_bytes);
> +    t_info_words = num_online_cpus() * pages * sizeof(uint32_t);
> +    t_info_pages = PFN_UP(t_info_first_offset + t_info_words);
>      printk(XENLOG_INFO "xentrace: requesting %u t_info pages "
>             "for %u trace pages on %u cpus\n",
>             t_info_pages, pages, num_online_cpus());