From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH 3 of 3] xentrace: remove unneeded debug
	printk
Date: Fri, 01 Apr 2011 12:18:37 +0100
Message-ID: <1301656717.9447.89.camel@elijah>
References: <patchbomb.1301508272@localhost>
	<eea91e2e4b452cb57398.1301508275@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <eea91e2e4b452cb57398.1301508275@localhost>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Olaf Hering <olaf@aepfle.de>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Acked-by: George Dunlap <george.dunlap@eu.citrix.com>

On Wed, 2011-03-30 at 19:04 +0100, Olaf Hering wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@aepfle.de>
> # Date 1301424082 -7200
> # Node ID eea91e2e4b452cb573982f4b47ecfa4c656e9547
> # Parent  3e95e737bc51c2295926e4f23389b1cb161d6d7b
> xentrace: remove unneeded debug printk
> 
> The pointer value in case of an allocation failure is rather uninteresting.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> 
> diff -r 3e95e737bc51 -r eea91e2e4b45 xen/common/trace.c
> --- a/xen/common/trace.c	Tue Mar 29 20:41:15 2011 +0200
> +++ b/xen/common/trace.c	Tue Mar 29 20:41:22 2011 +0200
> @@ -239,7 +239,6 @@
>      {
>          void *rawbuf = per_cpu(t_bufs, cpu);
>          per_cpu(t_bufs, cpu) = NULL;
> -        printk(XENLOG_DEBUG "xentrace: cpu %d p %p\n", cpu, rawbuf);
>          if ( rawbuf )
>          {
>              ASSERT(!(virt_to_page(rawbuf)->count_info & PGC_allocated));